alexanderomara/flarum-gravatar

Flarum Gravatar: Use Gravatar for user avatars

flarum-gravatar's Issues

Default Gravatar icon is being used even though 'Force Default Gravatar Icons' is disabled

Force Default Gravatar Icons is disabled, but it's still replacing the avatars for all users who have not uploaded a custom avatar yet. Default Flarum avatars have stopped showing up. Only Gravatars are showing for all users.

Boolean settings get not loaded correctly into settings dialog

I've noticed strange behavior with boolean settings and the modal settings dialog. I use Flarum beta 15.
If a boolean settings was ever changed, the settings dialog will display as checked every time when the settings page is reloded and settings dialog is opened, regardless of what was saved before.

To reproduce:

1. Enable extension
2. Open Settings
3. Check a checkbox
4. Save
5. Reload
6. Open Settings
7. Uncheck the checkbox
8. Save
9. Reload (important!)
10. Open Settings

The Checkbox will stay checked.

Looking into the Database, is seems like so:
When loading settings, null = unchecked, 0 or 1 = checked
When saving settings: 0 = unchecked, 1 = checked

Undefined variable: key

It looks like the extension works but I still get the following errors in logs:

flarum_1 | 2021/04/11 13:47:35 [error] 779#779: *4977 FastCGI sent in stderr: "PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60" while reading response header from upstream, client: 87.X.X.X, server: , request: "GET /api/users/3 HTTP/1.0", upstream: "fastcgi://unix:/var/run/php-fpm/php-fpm7.sock:", host: "flarum.example.com", referrer: "https://flarum.example.com/" flarum_1 | 2021/04/11 13:47:35 [error] 779#779: *4979 FastCGI sent in stderr: "PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60PHP message: PHP Notice: Undefined variable: key in /opt/flarum/vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 60" while reading response header from upstream, client: 87.X.X.X, server: , request: "GET /api/discussions?include=user%2ClastPostedUser%2Ctags%2CfirstPost&sort&page%5Boffset%5D HTTP/1.0", upstream: "fastcgi://unix:/var/run/php-fpm/php-fpm7.sock:", host: "flarum.example.com", referrer: "https://flarum.example.com/"

Cannot be installed with Flarum 1.0.0

Trying to install throws the following error:

Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires alexanderomara/flarum-gravatar ^1.4 -> satisfiable by alexanderomara/flarum-gravatar[1.4.0].
- alexanderomara/flarum-gravatar 1.4.0 requires flarum/core ^0.1.0-beta.16 -> found flarum/core[v0.1.0-beta.16] but it does not match your minimum-stability.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Syntax error on typed properties in PHP < 7.4

Flarum encountered a boot error (ParseError)
syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST)
thrown in vendor/alexanderomara/flarum-gravatar/src/Extenders/BasicUserSerializing.php on line 21