Giter Site home page Giter Site logo

alexandra-haynes / memes-collection Goto Github PK

View Code? Open in Web Editor NEW
9.0 2.0 14.0 2.88 MB

Join us in building a coding memes generator

Home Page: https://alexandra-haynes.github.io/memes-collection/

License: MIT License

HTML 15.34% JavaScript 84.66%
first-contribution firstcontribution firstpullrequest funny memes newbiefriendly opensource pull-request

memes-collection's Issues

Adding footer to the website

Title:

[Report/Suggestion]: Briefly describe the issue here


Type:

  • Inappropriate Content Report
  • Enhancement Suggestion

Description:

Please provide a detailed description. If you're reporting inappropriate content, specify which meme/joke and why you find it inappropriate. If suggesting an enhancement, describe what you'd like to see improved or added.


Location:

If reporting inappropriate content, please provide a link or the path to the file or location in the repository where the content can be found.


Additional Context:

Add any other context or screenshots about the report/suggestion here. For instance, if you're suggesting a feature, explain why you believe it would benefit the project.


Guidelines:

For Inappropriate Content:
We strive to maintain a positive and inclusive environment. If something is reported as inappropriate, it will be evaluated, and actions will be taken accordingly. When reporting, please be clear and constructive.

For Enhancement Suggestions:
All suggestions are welcome! If you have ideas on how to improve the project or its functionality, we'd love to hear them.

Update babel dependency

Title

The dev dependency for babel seems to be causing a problem when installing the node modules

Type

  • Enhancement Suggestion
  • Inappropriate Content Report

Description

Location

/package.json

Additional Context

Screenshot 2023-10-03 at 12 07 59 AM

After some research I saw this is a common bug with npm. One potential solution which worked for me was updating the babel dependency to version "^7.21.11". This is the latest version of the package.

https://www.npmjs.com/package/@babel/plugin-proposal-private-property-in-object

Add 2 new memes

Title: Add 2 new memes

[Report/Suggestion]: Briefly describe the issue here


Type:

  • Inappropriate Content Report
  • Enhancement Suggestion

Description:

I would like to add 2 memes to the page.


Location:

If reporting inappropriate content, please provide a link or the path to the file or location in the repository where the content can be found.


Additional Context:

Add any other context or screenshots about the report/suggestion here. For instance, if you're suggesting a feature, explain why you believe it would benefit the project.


Guidelines:

For Inappropriate Content:
We strive to maintain a positive and inclusive environment. If something is reported as inappropriate, it will be evaluated, and actions will be taken accordingly. When reporting, please be clear and constructive.

For Enhancement Suggestions:
All suggestions are welcome! If you have ideas on how to improve the project or its functionality, we'd love to hear them.

Header is not Visible on the hosted website

Title

Type

  • Enhancement Suggestion
  • Inappropriate Content Report

Description

Post merge #19, the header is not visible on the live page.

Location

/src/components/header

Additional Context

Not sure if we need to re-deploy or we are not rendering it correctly

Create components folder

Title

Code organization

Type

  • Enhancement Suggestion
  • Inappropriate Content Report

Description

There is no components folder. We should add that and move files like Jokes.js, and Memes.js to organize code. That way future components like header/footer have a place to go.

Location

/src

Additional Context

Screenshot 2023-10-03 at 12 29 40 AM

Fix the README.md file documentation

Title:

Actually everything is fine in the readme.md file only one thing is not correct there -

er

"Earn a T-Shirt: Complete the challenge and earn a limited edition T-shirt." because it is mentioned in the FAQ section of hacktoberfest site that this year there is no t-shirt reward.

link - https://hacktoberfest.com/participation/#faq
sol

So, by removing or correcting that point from the readme.Md file , this issue can be solved


Description:

Please provide a detailed description. If you're reporting inappropriate content, specify which meme/joke and why you find it inappropriate. If suggesting an enhancement, describe what you'd like to see improved or added.


Location:

2nd point - https://github.com/Alexandra-Haynes/hacktoberfest2023-memes-collection#why-contribute


Additional Context:

Add any other context or screenshots about the report/suggestion here. For instance, if you're suggesting a feature, explain why you believe it would benefit the project.


Guidelines:

For Inappropriate Content:
We strive to maintain a positive and inclusive environment. If something is reported as inappropriate, it will be evaluated, and actions will be taken accordingly. When reporting, please be clear and constructive.

For Enhancement Suggestions:
All suggestions are welcome! If you have ideas on how to improve the project or its functionality, we'd love to hear them.

Random Joke and Meme Generator

Title:

Random Joke and Meme Generator

Description:

You idea of displaying all the memes and joke is nice but if the number of memes and joke keep on increasing then the website will grow to big vertically. So to avoid this we can make this website as a random Joke or Memes generator were anyone can click on a button to get a new joke or a new meme as they like and thus the vertical length will also be reduced.


Location:

I would like to make these changes in "src" folder of this repository were i might edit the existing js file or even create new more files as per the need.

For Enhancement Suggestions:
I am quite experienced person with good front end knowledge so i would also like to work on some UX part of the website if you agree.
But for now i wish if we could make this website of your as random joke and memes generator.
Where beginners can continue with giving their memes and jokes as usually and developers like me can update the appearance and feature of the website.

@Alexandra-Haynes

Create a header component

Title

  1. Create a header component in src/components
  2. Import inside App.js
  3. Render it above Memes

Type

  • Enhancement Suggestion
  • Inappropriate Content Report

Description

The header should have a title of the project, and a link to the Github repository

Location

Additional Context

Layout: Generate Button

Title

The generate button under the meme needs some padding or margin to keep consistent layout with the generate button under jokes

Type

  • Enhancement Suggestion
  • Inappropriate Content Report

Description

Location

src/GlobalStyle.js

Additional Context

Screenshot 2023-10-03 at 3 00 39 PM

Update Read me file

Title

Since the project has been excluded from the hackathon, we should get rid of the hackfest info.

Type

  • Enhancement Suggestion
  • Inappropriate Content Report

Description

Remove all hacktober fest details

Location

readme file

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.