alexandruradovici/alf-semantic-ast-public

alf-semantic-ast-public's Issues

Expression types

{Variable definition with expression}
define e => int is 20+3*5;

Here shouldn't we determine the type of the expression 20+3*5 and display it in the ast?

Array index value

i get an error on vmchecker for this test https://github.com/alexandruradovici/alf-semantic-ast-public/blob/master/verify/alfy/6_error/array_index_value.alfy.json but my output seems to be alright

Work environment

Where should we work with the symbol table, ast and error list for homework 3? In the main file or jison file?

Required types for comparators

Why are the types required when making a comparation? If the types cannot be compared isn't the result false?

Value of symbol for function nodes

Why is the value of the symbol key in the function nodes 1? Shouldn't it be 0?

Function redefinition

for this test https://github.com/alexandruradovici/alf-semantic-ast-public/blob/master/verify/alfy/6_error/function_redefine.alfy.json my result seems to be ok but on vmchecker i get an error for the ast saying my types are int and that they should be ""

Line in AST

In the AST, isn't the last line supposed to be line: 2? instead of line: 3?

https://github.com/alexandruradovici/alf-semantic-ast-public/blob/master/verify/alfy/1_variable_definition/variable_with_expression.alfy

https://github.com/alexandruradovici/alf-semantic-ast-public/blob/master/verify/alfy/1_variable_definition/variable_with_expression.alfy.json

Line error?

The line isn't supposed to be 3? because after it parses the rule it should be line: 3, not line: 2.
It's confusing because the "attribution" test and "variable_with_expression" test are displaying the last line+1 like you said it's supposed to, and all of the other tests from variable_definition are displaying just the line where the last instruction is.

https://github.com/alexandruradovici/alf-semantic-ast-public/blob/master/verify/alfy/1_variable_definition/simple.alfy

https://github.com/alexandruradovici/alf-semantic-ast-public/blob/master/verify/alfy/1_variable_definition/simple.alfy.json

Type of valueof node in AST

The type of the valueof node from the test 'Function definition with statements and value' is "" even though the function returns int :)

Value of lines

Some of the tests have weird values for the line keys. For example, in the variable_list test, all the lines are set as 5, even though the variables are defined on different lines. In other tests, such as the ones for functions, the last line's value(for the script node) is the number of lines in the file + 1. Are those correct?