alco's Issues
Code Review
Важные замечания
Занеси объявление констант в функцию getrandom() - это позволит быстро изменить диапазон рандома:
Lines 35 to 36 in fcc0972
Также это упростит данную запись:
Lines 37 to 38 in fcc0972
Реализуй отдельную функцию:
Line 39 in fcc0972
Объяви константу result и верни ей результат функции result(), имя которой нужно сделать более понятным:
Line 41 in fcc0972
Лишнее отбрасывание дробной части:
Lines 23 to 24 in fcc0972
Ненужная функция:
Lines 14 to 20 in fcc0972
GRAMMAR NAZI
После служебного слова ставим пробел:
Line 34 in fcc0972
Line 41 in fcc0972
Операторы окружаем пробелами:
Lines 23 to 26 in fcc0972
Lines 30 to 31 in fcc0972
Line 39 in fcc0972
Соблюдать правила форматирования кода:
Lines 2 to 13 in fcc0972
Lines 21 to 28 in fcc0972
Lines 41 to 49 in fcc0972
Непонятные имена констант:
Lines 37 to 38 in fcc0972
При перечислении параметров после запятой ставим пробел:
Line 2 in fcc0972
Line 21 in fcc0972
Line 29 in fcc0972
Lines 37 to 38 in fcc0972
Lines 40 to 41 in fcc0972
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.