alexeymuranov/raclette

Custom alternative to Galette "Gestionnaire d'Adhérents en Ligne Extrêmement Tarabiscoté mais Tellement Efficace"

raclette's Issues

Related to your rails issue

Hi there,

your rails issue rails/rails#7236 got me a bit baffled, as to why you would do anything like that. So I took a look at your code, and as far as i can tell, inside your EventsController you need to define your classes again because you want to be able to define some constants on class level, but which could change per controller.

Because you inherit from the original model, you also have to redefine all your relations you want to use.

I hope you feel your current solution is going wrong, against the framework. It is not simple, it is not clean, it is frankly awful.

Why do not something simple, like:

class EventsController < SecretaryController
  CONFIG = { :event => { :all_sorting_columns => [ :title, :event_type, :date, :start_time,  :supervisors ],
                                            :default_sorting_column => :date},
                        :weekly_event => { :all_sorting_columns => [ :title, :event_type, :lesson, :week_day, .... <snip> ],
                                                           :default_sorting_column => :end_on
                         :person => { :all_sorting_columns => [ :ordered_full_name,  :email ],
                                                :default_sorting_column => :ordered_full_name }
                         :member => { :all_sorting_columns => [ :ordered_full_name, :email, :account_deactivated, :tickets_count ],
                                                  :default_sorting_column => :ordered_full_name }

and use that instead?

As I understand it, you are trying, per controller, to store some configuration how everything should be shown.
My suggestion expresses your intent much more clearly that what you are now trying to do now (in my personal opinion).

If you do it like I propose, it not only becomes much clearer, but it also would not be a big change to load this configuration from yaml or some user-configuration instead.

Hope this helps.

Find a proper way to download resources in zip/gzip

Current implementation sends generated zip file in attachement in response to a request for, for example, CSV representation (inline).