alexhuszagh/breezestylesheets

Breeze/BreezeDark-like Qt StyleSheets

About Me

Just a former biologist who got bored enough with Excel to start writing scripts to automate that process. Next thing, I'm optimizing floating-point parsers cross-compiled to a Raspberry Pi. Thinking is overrated and we should do less of it.

A few of my accomplishments:

• Author of the Rust core library float parser.
• Creator of rust-lexical, which implements fast float parsing and writing algorithms, used in polars and more.
• Designed the digit comparison algorithm for unambiguous floating-point parsing for near-halfway cases, used in fast float and rust-lexical.
• Designed stylish, customizable light and dark Qt stylesheets.
• Maintainer for cross-rs, for minimal setup cross-compilation on Rust.
• Author of xcross, a port of cross-rs for C/C++ projects with vcpkg and conan integrations.
• is unable to think during the summer heat.

Stats

breezestylesheets's Issues

Typo issue in breeze_resouces.py

Hello,

First I would like to thank you for your great work!

There is a small typo issue in the filename.
There is a missing r at the end. It should be breeze_resources.py. So the file dark.py and light.py are returning an error.

Thanks.

[BUG] Placeholder Text in QLineEdit Not Greyed Out

Description

Normally, placeholder text when a text edit is empty should have a different display color than the regular text. However, QLineEdit does not have this currently, incorrectly showing it as the same display color. This also affects editable QComboxes.

[BUG] QColumnView Size Grip Expands View

Description

Hovering over the size grips in a QColumnView expands the widget, and does not trigger the size grips correctly. Dissecting the issue, I've found the offending commit is the patch for #11, specifically, d620f22, and the offending code is:

QWidget:disabled:hover
{
    background-color: ^background^;
}

Removing this fixes the issue, however, it might cause ripple effects.

Overhaul Windows UI

Right now, there's a few issues that lead to massive issues with the Windows UI. This will be a status update, with incremental fixes being displayed.

Ugly Table Sort Arrow

Issue

The table sort arrow currently is placed at the top, with padding, which leads to some unsightly UIs, and isn't great for the default.

[BUG] QCheckbox in QTreeView not Rendering in Qt6

Description

The QCheckBox in a QTreeView don't render when not hovered, and are either grayed out (tristate) or invisible.

Groupbox does not show border

Looks very good! I'm missing borders on my groupboxes though. Know how to fix this or enable them?

[BUG] Placeholder Text for QPlainTextEdit not Greyed Out

Description

The placeholder text for a QPlainText edit is rendered the same as the regular text, making it difficult to visually distinguish it from real text. This will likely also affect QTextEdit.

Potentially related to #41.

Is this project abandoned?

While I don't want to tell anybody in an open source project how to spend their time, I've posted an issue (#14) a month ago and received no responses.
I also see that the last merge (#9) is from late 2018 and the last reply from the repo owner is early 2019 (#10) with a fix for an issue from another user that was never merged (#13).

I'm guessing if I don't get a reply that this project is abandoned, I hope this issue will help other (potential new) users understand the status!

[BUG] No Hover Event for QCompleter in Qt5

Description

There is no hover event properly highlighting the selected element in a QCompleter in Qt5 (works in Qt6). Right here, "Fruits Basket" is hovered, but there's no highlight event.

Consider supporting githubuser0xFFFF/Qt-Advanced-Docking-System

Hello

The advanced docking system is really a great docking system for Qt. It uses an internal stylesheet to make it look like this:

When trying to use the stylesheet provided here without any changes, this happens:

What happens is that Qt-ADS uses an internal stylesheet to keep things in order.

If the internal stylesheet is disabled, this happens:

Notice how in particular the icons are wrong (like a double icon in one of them), and the tabs aren't clear, etc.

I guess it would require these things:

https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/tree/master/src/stylesheets

To be included in the theme.

Anyway, thanks for this work! It's amazing!

Bug Using Test Suite with Default Settings

Description

Running the test suite currently raises an error of an invalid widget type if called without using --widget all. This should be the default.

$ python3 test/ui.py
Traceback (most recent call last):
  File "/home/ahuszagh/git/BreezeStyleSheets/test/ui.py", line 963, in test
    function = globals()[f'test_{test_widget}']
KeyError: 'test_None'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ahuszagh/git/BreezeStyleSheets/test/ui.py", line 1031, in <module>
    sys.exit(main())
  File "/home/ahuszagh/git/BreezeStyleSheets/test/ui.py", line 1026, in main
    test(args, sys.argv[:1] + unknown, args.widget)
  File "/home/ahuszagh/git/BreezeStyleSheets/test/ui.py", line 965, in test
    raise NotImplementedError(f'test for {test_widget} not implemented')
NotImplementedError: test for None not implemented

[BUG] No Highlighting on Triangular QTabBars

Description

Unlike rounded QTabBars, the triangular ones do not have highlighting for the selected or hovered items.

Rounded

Triangular

Enable Customizing Colors

A major enhancement has been the use of templates to auto-generate most of the files. This means that customizing your own color palettes should be doable, which might be great, say, for using purple or green for highlights rather than blues for custom themes.

[BUG] QToolButton in QTabBar has Transparent Background and 2 Arrows

Description

QToolButton in a QTabBar has both the border-image and image subcontrol pixmaps, and the background is transparent, leading to difficulty distinguishing it from the QTabBar itself and the arrow itself is difficult to view.

Related to #47.

[BUG] Insufficient Padding on Triangular, Closable QTabWidgets

Description

The triangular QTabBars in a QTabWidget do not have sufficient padding, leading to the close buttons overlapping with the borders.

Missing Icons in Test Suite

Description

Running the test suite with all widgets produces the following error messages:

qt.svg: Cannot open file ':/native/close.svg', because: No such file or directory
qt.svg: Cannot open file ':/native/close.svg', because: No such file or director

QFileDialog icons are missing

When using PyQT5 and either light or dark theme, the icons in a QFileDialog are not there, and just empty buttons.

Without the theme:

Called with the code:

        filename = QtWidgets.QFileDialog.getOpenFileName( self, caption="Open Video")

Edit: Super simple program that auto opens the dialog to test with:

import sys

from PyQt5.QtCore import *
from PyQt5.QtWidgets import *

import breeze_resources

class Window(QMainWindow):
    def __init__(self, parent=None):
        super().__init__(parent)
        self.resize(400, 200)
        QFileDialog.getOpenFileName()
        raise Exception("end app")

if __name__ == "__main__":
    app = QApplication(sys.argv)
    file = QFile(f":/light/stylesheet.qss")
    file.open(QFile.ReadOnly | QFile.Text)
    stream = QTextStream(file)
    app.setStyleSheet(stream.readAll())
    win = Window()
    win.show()
    sys.exit(app.exec_())

How to use this with CMake

Hey! Thanks again for all the support with Qt-ADS!

I wanted to give something back, so here's a text on how to use your amazing work with projects built with CMake. Feel free to include it on your readme if you want:

First, this is what you need on your cmake file:

# This is how I usually setup Qt (makes it work with both Qt5 and Qt6 at the same time
# Setup Qt
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_AUTOUIC ON)

find_package(
  QT NAMES Qt6 Qt5
  COMPONENTS Core
  REQUIRED)
find_package(
  Qt${QT_VERSION_MAJOR}
  COMPONENTS ${AE_REQUIRED_QT_COMPONENTS}
  REQUIRED)
# -------------------

# For this library:

# Get Python
find_package(Python COMPONENTS Interpreter)

include(FetchContent)

set(FETCHCONTENT_QUIET
    OFF
    CACHE BOOL "Silence fetch content" FORCE)

FetchContent_Declare(
  breeze_stylesheets
  GIT_REPOSITORY https://github.com/Alexhuszagh/BreezeStyleSheets.git
  GIT_TAG origin/master
  GIT_PROGRESS ON
  USES_TERMINAL_DOWNLOAD TRUE)

FetchContent_GetProperties(breeze_stylesheets)
if(NOT breeze_stylesheets_POPULATED)
  FetchContent_Populate(breeze_stylesheets)

  add_library(breeze_themes STATIC "${breeze_stylesheets_SOURCE_DIR}/breeze_themes.qrc")

  add_custom_target(
    run_python_breeze ALL
    COMMAND ${Python_EXECUTABLE} configure.py --extensions=advanced-docking-system
            --styles=dark-green,light-green --resource breeze_themes.qrc
    WORKING_DIRECTORY ${breeze_stylesheets_SOURCE_DIR}
    BYPRODUCTS "${breeze_stylesheets_SOURCE_DIR}/breeze_themes.qrc"
    COMMENT "Generating themes")

  add_dependencies(breeze_themes run_python_breeze)

endif()

And then, add your executable and link with the created library:

add_executable(myapp WIN32 MACOSX_BUNDLE "main.cpp")
target_link_libraries(myapp PRIVATE Qt${QT_VERSION_MAJOR}::Widgets breeze_themes)

On your main.cpp file you need to manually init the resources because they are coming from an external library:

// ...
QApplication qapp(argc, argv);

Q_INIT_RESOURCE(breeze_themes);
QFile file(":/dark-green/stylesheet.qss");
file.open(QFile::ReadOnly | QFile::Text);
QTextStream stream(&file);
qapp.setStyleSheet(stream.readAll());

CMake install

The CMake install documentation still lists a file called "breeze_themes.qrc". Looks like this file got renamed to "breeze.qrc".

[BUG] QTabBar With Scroll Buttons Renders Incorrectly

Description

Using a QTabWidget with the QTabBar to use scroll buttons has the scroll button icons empty, and the icons aren't padded.

Clear Text Icon in QFileDialog is Misplaced

Issue

In a QFileDialog, the clear text icon has too much padding on the top, and therefore renders poorly. These are images on Linux using KDE Plasma.

Native

Dark

[BUG] QDial not Styled

Description

The QDial does not have correct styles, leading to too dark notches and too light background styling in the dark theme. The light theme is better, but potentially could be made better.

Incorrect Arrow Placement on QToolButton in Qt6

Issue

The arrows attached to QToolButton's with the popup modes incorrectly overlap with the text in Qt6, but not Qt5.

Qt6

Qt5

QHeaderView Sections not Properly Padded in Qt6

Issue

Using text-align: center;, the sections are still incorrectly padded on the bottom (for vertical elements) and on the right (for horizontal elements). This only occurs in Qt6.

Qt6

Qt5

This also affects the solution for #35.

UI File

Where can I find the ui file

[BUG] QCalender Arrows and Month Selection Render Incorrectly

Description

The forward/back arrows and the month selection are rendered incorrectly. This is an issue in both Qt5 and Qt6.

Qt5

Qt6

[BUG] QToolButton with Arrow Is not Styled

Description

The arrow type for the QToolButton is not rendered properly, on Qt5 or Qt6.

Qt5

Qt6

[BUG] QColumnView Has Border When not Focused

Description

When not focused, a QColumnView has a border around it. It should potentially have a highlight border when hovered/selected, but it should not have a border when not focused.

Auto-Raise QToolButton Hover/Pressed/Checked Highlight Uses Wrong Colors in Qt6

Issue

The highlight background and outline for hover, pressed, and checked events uses the wrong colors for auto-raised QToolButtons in Qt6.

Qt5

Qt6

Disabled menu can't be seen completely in dark theme

Hi

I like how light theme behave. The disabled menu/button still appear and readable but can't be selected/highlighted. In contrary, those menu/button in dark theme completely unreadable

is this expected behavior ?

Thanks for Breeze

[BUG] QScrollBar is too Large

Description

The width of the QScrollBar is too large. This is likely related to b37e73b.

Checkbox not shown in dark mode

When using the dark stylesheet, checkboxes are not displayed properly. Only the test is visible. See attached images comparing the default Qt stylesheet versus the dark stylesheet.

Qt 6.2.2 with C++ in Visual Studio 2022 with Qt Visual Studio Tools version 2.8.1 (rev.6)

[BUG] QSlider Ticks Invisible

Description

The ticks for a QSlider widget are the same color as the background in both the light and dark themes.

Test Suite Produces Error on QDialog Exec in PyQt6

Issue

In test/ui.py for test_issue25, we incorrectly called dialog.exec_() rather than dialog.exec() in PyQt6.

Unexpected Table Item Padding in PyQt6

Issue

Using PyQt6, the table items/headers have unexpected padding under the elements, which means with the default item sizes they are practically illegible. This differs friom both the native theme and PyQt5.

PyQt6 Dark

PyQt5 Dark

PyQt6 Native

QDialogButtonBox minimizes horizontally

First of all, it is a very nice work.

The buttons contained by QDialogButtonBox are minimized like in the image below:

[FEATURE] Add Complete Standard Icon Pack

Problem

For applications that wish to override all standard icons to fit with the BreezeStyleSheets theme, we currently do not provide a complete icon set.

Solution

This could be provided as an extension, with SVG icons provided for all standard icons.

[BUG] Checkable Groupbox Stays Highlighted Even When Inactive

Description

An unchecked groupbox keeps its highlight even when the item is not hovered or focused.

Simplify Tracking/Untracking Build Files

Issue

We want to ensure files in the dist directory are tracked for the default themes, but should be able to untrack/retrack these files when developing custom themes or files with extensions, to avoid updating resource files unnecessarily in Git.

Borders on windows

Hi, I decided to learn something about PyQt so started developing some simple app. I'm working on Linux, but I would like to run my app on windows also. I really like the dark style whick looks great on Linux.
I noticed that when I run it on Windows 10, borders around almost all widgets are missing. For example that nice blue border around buttons when hovered. Do you know some quick fix for this?

Thank you for your work!

breeze.qrc is not used by dark.py and light.py

pyrcc5 could be used to convert breeze.qrc to breeze_resources.py and import in dark.py and light.py.

Question: compiling and adding to project

I may want to add this to a project I am working on and have a question on this;
The readme says to compile the style sheets to use them. Does that mean that every user of the project need to compile the dark theme or when does this happen?

If the theme needs to be compiled every time, is there a trick to have this be done automagically on the first time the software runs?

qt.svg can't open some svg files

qt.svg: Cannot open file ':/dark/transparent.svg', because: No such file or directory
qt.svg: Cannot open file ':/dark/transparent.svg', because: No such file or directory
qt.svg: Cannot open file ':/dark/transparent.svg', because: No such file or directory
qt.svg: Cannot open file ':/dark/transparent.svg', because: No such file or directory
qt.svg: Cannot open file ':/dark/down_arrow.svg', because: No such file or directory
qt.svg: Cannot open file ':/dark/down_arrow.svg', because: No such file or directory

Style seems applied sucessfully, but some details lost.

I'm using Qt5.11 with C++ on msvc14.

THX

[BUG] QDateTimeEdit with Calendar Popup has Incorrect Menu Indicator

Description

Using QDateTimeEdit with calendarPopup enabled leads to a distorted menu indicator.

No breeze.py

dark.py and light.py need breeze.py which doesn't exist.

And, app->setStyleSheet() should be app.setStyleSheet().

Move Configured Templates to `dist`

Issue

Configured files should be isolated from the remaining project files, and all exist under dist/. PyQt6 uses a different resource system than PyQt5 and C++ Qt, so these should have different subdirectories since both the light and dark themes without extensions for both resources should be tracked by Git.

Standard Icons are not Overwritten

Issue

Standard icons are only being overwritten in QDialogButtonBox and QMessageBox, leading to ugly icons like the following:

This is because the icons are only overwritten here:

QDialogButtonBox
{
    dialogbuttonbox-buttons-have-icons: true;

    dialog-cancel-icon: url(^style^dialog_cancel.svg);
    dialog-close-icon: url(^style^dialog_close.svg);
    dialog-ok-icon: url(^style^dialog_ok.svg);
    dialog-open-icon: url(^style^dialog_open.svg);
    dialog-reset-icon: url(^style^dialog_reset.svg);
    dialog-save-icon: url(^style^dialog_save.svg);
    /**
     *  No support yet for overriding saveall.
     *  dialog-saveall-icon: url(^style^dialog_saveall.svg);
     */
    dialog-yes-icon: url(^style^dialog_ok.svg);
    dialog-help-icon: url(^style^dialog_help.svg);
    dialog-no-icon: url(^style^dialog_no.svg);
    dialog-apply-icon: url(^style^dialog_ok.svg);
    dialog-discard-icon: url(^style^dialog_discard.svg);
}

QMessageBox
{
    messagebox-critical-icon: url(^style^message_critical.svg);
    messagebox-information-icon: url(^style^message_information.svg);
    messagebox-question-icon: url(^style^message_question.svg);
    messagebox-warning-icon: url(^style^message_warning.svg);
}

Solution

This might not be possible with stylesheets (it's unlikely), so I need to clearly document how to do this with actual code.

Question for MIT compliance

Hi, thank you for your project, I added generated theme into my opensource (MIT) project:
https://github.com/mapron/d2modgen
I already added link in "Used thirdparty products" in readme.md. Though not sure if it's enough.
I am not adding your sources to my repo; also, I do not distribute full license with binary package (so in binary release, you can't see thirdarty license).
Is it ok for you? Fair enough?

[BUG] QColumnView Arrows not Styled

Description

QColumnView uses the default arrows for expanding/collapsing widgets.