alexrudy/cauldron

Locally-hosted Keck Telescope Library for Keywords

cauldron's Issues

[ENH] The broker should remember keywords which it sees broadcast

Keywords broadcast through the ZMQ broker should be remembered for future identify commands.

Some keywords have erroneous bytes appended in ZMQ mode.

Sometimes keyword values have \x01 appended in ZMQ mode. This is from the FRAMEBLANK constant in Cauldron.zmq.microservice, but probably speaks to an error in micro service or the broker, both of which could be simplified a little bit.

Intermittent ImportError

Sometimes Cauldron.use will trigger an import error here:

        # Install the dispatcher side libraries.
        from Cauldron import _DFW
        _DFW = sys.modules.setdefault('Cauldron._DFW', _DFW)
>       reload(_DFW)
E       ImportError: Loaded module Cauldron._DFW not found in sys.modules

This consistently happens in specific tests which seem to vary with machine and additional factors. I can't seem to reliably track it down.

Oddly enough, when the tests continue, everything is fine. Also, PDB doesn't show this is actually the problem (i.e. in PDB, 'Cauldron._DFW' is indeed in sys.modules)

Notice: You might be using enable_deprecations_as_exceptions that is removed in astropy v6

This is an automated issue from Astropy. You might be using code removed in astropy v6.0.dev from astropy/astropy#14670 in the following files:

* Cauldron/conftest.py

Please use https://docs.pytest.org/en/stable/how-to/capture-warnings.html instead.

If this issue is opened in error or irrelevant, feel free to close. We apologize for any inconvenience caused.

Descriptors should fully replace keyword methods

For everything except callbacks, Keyword Descriptors should singularity replace a keyword method. This way, e.g. replacing .postwrite() can be done simply by the user at runtime, and skip calling the original method. The current argument passing scheme is kind of a hack, and it should be removed.

The callback event (which hooks into _propogate) should still be allowed from multiple descriptors to multiple keywords.

The event structure currently implemented is still useful beyond callback, but it should instead raise an error when there are multiple method replacements occurring.

Don't auto-start broker by default.

Starting the broker by default in the background is a bad idea.