alexruiz/fest-util

FEST Common Utilities

fest-util's Issues

Update project to use Java 6. Clean up code.

Java 5 is EOL.

Also, clean up code: missing @OverRide annotations (Java 6 allows this annotation for implementing methods,) formatting and copyright year.

Revert methods that return Iterable to return List (as it was originally intended)

Returning Iterable is, IMHO, a bad idea. You cannot ask an Iterable about its size, and you cannot access elements by index.

The methods that I plan to revert are in the Properties class.

Move back factory of primitive arrays from fest-util back to fest-assert

FEST-Util is supposed to contain utilities that are used by more than one FEST module. So far, only FEST-Assert needs it.

Store Eclipse preferences for 'Formatter', 'Save Actions' and 'Clean Up' in project

Rename class 'Systems' to 'SystemProperties'

Published JAR contains instrumentation files

Hi, I noticed what looks like some build files in the fest-util JAR. Not sure if this is intentional or not, but I thought I'd let you know!

$ jar tf fest-util-1.1.6.jar
...
groverconfig185938829795527555/
groverconfig5391273288001679207/
groverconfig543396759037330044/
groverconfig8484026481059111655/
groverconfig185938829795527555/instrumentation.ser
groverconfig5391273288001679207/instrumentation.ser
groverconfig543396759037330044/instrumentation.ser
groverconfig8484026481059111655/instrumentation.ser

Move creation of ArrayLists into a Lists class

Also remove the overloaded methods that take one and two arguments. For the first case, java.util.Collections has the method SingletonList. For the second one, I don't see the value. We need to keep the API as small as possible.

remove dependency on AWT to be Android compatible

It appears to me that the AWT dependencies have still not been removed from fest-util tagged 1.2.3 and 1.2.4, even though they were removed from the master. I believe that this is probably a mistake due to this discussion:
alexruiz/fest-assert-2.x#103

I checked the tags for both 1.2.3 (which fest-assert-core 2.0M8 depends on) and 1.2.4 (which fest-assert-core 2.0M9 depends on) and both still have a ToString class that references AWT:
https://github.com/alexruiz/fest-util/blob/fest-util-1.2.3/src/main/java/org/fest/util/ToString.java
https://github.com/alexruiz/fest-util/blob/fest-util-1.2.4/src/main/java/org/fest/util/ToString.java

This prevents people using Android from using Fest.

Rename 'isEmpty' to 'isNullOrEmpty'

The name 'isEmpty' is deceiving.

Move creation of Sets to Sets class

Also remove overloaded versions that take one and two parameters.

Iterables.sizeOf(Iterable<?> iterable) runs into inf. loop for non-collection Iterables

Iterator<?> iterator = iterable.iterator();
while (iterator.hasNext()) {
size++;
}

The .next() is missing.

By the way: Why did you bake your own Iterables etc. utility classes? I would suggest to use the guava lib for these tasks.

Add Collections.set() for backwards compatibility

Some of my code breaks now because of this violation of backwards compatibility. Collections.set() is used e.g. ObjectGroupAssert.containsOnly().

I can add it if you want :)

Move Iterable-related methods out of the Collections class

It is wasteful to create Iterators for Collections to check if a Collection is empty or to get its size.