alextts627/alexnodejs

alexnodejs's Issues

improve - users.post and put - check body variables

parse req.body and check if variables exist

and check if variables meet the date type or rules of db schema and user stories.

ex:
email is english + number @ english + number . com/net/(string length = 3)...etc

(finished)improve - users.login - use regular expression to filter email and acc

acc to filter lowercase of english and mix number

improve - users.get - db variable

//filter sql injection, example
var users_id = req.params.id;
users_id = filter(users_id);
var db_query = 'SELECT * FROM users = ''+ users_id + ''';

//orm, example
db = users();
db->uid = req.params.id;
db->save();

(finished)imrove - users.delete - remove code

remove unnecessary code in db query for account check exist

improve - users.put - dynamic sql query by req.params

dynamic sql query by req.params

improve - users - all method - db check id before real sql query

run db uid check before reql sql query

(finished)improve - users.post - indentation

var cmdVal = {
"Acc" : reqObj.Acc,
"Pass" : reqObj.Pass,
"Email" : reqObj.Email,
"Create_time" : now()
};

(finished)improvement - users.get

please judge if req id exist before proceed to DB