alfredoramos/phpbb-ext-seo-metadata

SEO Metadata extension for phpBB

phpbb-ext-seo-metadata's Issues

Error update to 1.1.0

Use ext version 1.0.0

I have Disable -> Delete data -> Delete all the files inside {PHPBB_ROOT}/ext/alfredoramos/seometadata/ -> Download on: https://github.com/AlfredoRamos/phpbb-ext-seo-metadata/releases/tag/1.1.0 -> upload & extract -> enable ext & have error

`Something went wrong during the request and an exception was thrown. The changes made before the error occurred were reversed to the best of our abilities, but you should check the board for errors.

A module already exists: ACP_SEO_METADATA`

Can you help me?

Support for meta description

Suggested via phpBB topic.

Wrong description on viewforum

It should include the forum description if available, however since commit 43767de that is no longer possible.

Split functional tests

Split tests by category, currently:

• ACP
• Topic / Forum

Missing field "url" (in "author")

Hello, Alfredo.

Thanks a lot for this great extension. It helped me to save a lot of time to include all these SEO metadata :D

In my search console, I am having this error (non-critical):

Missing field "url" (in "author")

Searching for this error, I could find this links:

https://support.google.com/webmasters/thread/245921519?hl=en&msgid=246028957

Could this field be added to the next version of this extension?

Kind regards,

Og:image doesn't have a default

Is there a way to set a default og:image like a logo if it cannot find a image in a post for Facebook.

Thanks

Does upgrade require complete uninstall? (bug or feat. request)

Hi,

does upgrading from a previous version requires:

1. a complete uninstall (including deleting its data, that is the configuration) or

2. is it enough to disable the extension, delete the files under /forum/ext/ , replace them with the new version and then enable the extension again, without the need to delete data and thus re-enter the config from scratch?

If it's true the former (1), take this as a feature request: if possible, please avoid that need, as having to re-enter the config at every update is quite inconvenient.

OTOH, if it's true the latter (2) then there's a bug in the README.md file, as in the upgrade instructions it states "Uninstall the extension" rather then "Disable the extension".

Thanks. :-)

twitter card not completely extracted

Hi,
Compliment for your work!
Works fine, but i not understand why not extract twitter card
Extract only

<meta name="twitter:card" content="summary">
<meta name="twitter:site" content="@homekititalia1">

but
tag <meta name="twitter:image"> not displayed.
tag <meta name="twitter:title"> not displayed.
tag <meta name="twitter:description"> not displayed.
i'm using version 1.2.0-beta2

It should include Ope Graph image dimensions

Reference:

• https://www.phpbb.com/community/viewtopic.php?p=15279406#p15279406

Also add the MIME type.

Image extraction doesn't always return an array

sorry for the low quality of this bug report. i'm just passing along information as i get it.

phpBB 3.2.8
php (fpm) 7.2.24
postgresql 9.6.15
SEO Metadata 1.2.0

a user sent me these error messages

[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 146: Illegal string offset 'url'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 146: Illegal string offset 'url'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 146: Cannot assign an empty string to a string offset
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 159: Illegal string offset 'url'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 165: Illegal string offset 'url'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 166: Illegal string offset 'type'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 167: Illegal string offset 'width'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 168: Illegal string offset 'height'
[phpBB Debug] PHP Warning: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 176: Illegal string offset 'url'

i have no idea what he was doing when he got that error. i'm trying to get more info out of him.
i can also try to look in logs if you're curious. not sure where to look though.

https://www.phpbb.com/customise/db/extension/seo_metadata/support/topic/209426

SVG logo is not accepted

When trying to use a svg for the JSON-LD publisher logo, the following message is received:
Invalid values for fields: Publisher logo

Image extraction does not get inline attachment images

Issue reported via email

Infinite loading - timeout

I've found a bug that prevent topic from displaying.

Steps to reproduce:

1. Create a topic and put an image from external website that keeps loading forever (returns timeout). E.g sample
2. Turn on seo metadata extension
3. Go to the previously created topic

Result: phpbb3 also returns timeout. 😢

There would be nice to have a feature that is trying to check out image dimensions only for like 2 or 3 seconds and give up if it doesn't work.

<meta property="og:image*> is sometimes missing on some HTTPS sites

This extension uses FastImageSize->getImageSize(), which in its turn calls @file_get_contents(), which silently fails with an SSL error "SSL operation failed with code 1..." As a result, og:image tags disappear without a trace. This doesn't happen on every server and probably depends on server config. The problem is that you use the full absolute URLs (https://etc) for local images when performing local routines like checking image dimensions etc. Please 1) make URLs absolite only in the last step, when sending them to template; 2) write to the error log when attachments that certainly exist cannot be obtained for some reason.

Example:

file_get_contents('./image.png'); // OK
file_get_contents('https://site.com/image.png'); // Fail

Refs:
Typical related discussion:
https://stackoverflow.com/questions/26148701/file-get-contents-ssl-operation-failed-with-code-1-failed-to-enable-crypto
PHPBB bugreport:
https://tracker.phpbb.com/browse/PHPBB3-16742
FastImageSize bugreport:
marc1706/fast-image-size#61

JSON-LD is missing some data

According to the Google Search Console, it's missing the following data:

• author
• datePublished
• publisher

Inconsistencies in migration files

Attachments were added in version 1.1.0, but they're included in migration files under migrations/v10x (version 1.0.0).

Image info issue in helper::validate_image()

It throws the following notice:

([phpBB Debug] PHP Notice: in file [ROOT]/ext/alfredoramos/seometadata/includes/helper.php on line 1103: Trying to access array offset on value of type bool)

Reference:

• https://www.phpbb.com/customise/db/extension/seo_metadata/support/topic/218476

Use forum image too

Reported in the support section at phpbb.com

https://www.phpbb.com/customise/db/extension/seo_metadata/support/topic/208496?p=708446#p708446

It would use the first available, with a fallback to the next level:

• Image extracted from topic
  • Forum image
    • Default image

Warning in helper::extract_image()

The pull request #45, part of the reseased version 1.3.0, re-introduced a similar bug to #39 in the helper::extract_image() that gives the following warning.

[phpBB Debug] PHP Notice: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 126: Trying to access array offset on value of type null

Image dimensions for JSON-LD logo are not being deleted if image field is empty

If an empty JSON-LD logo is sent, it still shows previous image dimensions.

[Twitter Cards] Add support for summary with large image

Suggested via email.

https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/summary-card-with-large-image

Spanish translations need to be updated

In #14 new ACP configurations were added.

Use DOM to extract images instead of regular expression

This was also a validation note.

helper#extract_image() does not match images with query string in the URL

helper#extract_image() does not match images containing a query string in their URL. For example the following image will be ignore due to \.(?:jpe?g|png|gif)$ looking for the file extension to be the last thing in the URL: <img src="www.example.com/my-image.jpg?h=400&w=500" alt="" />.

Query strings in images src is useful when dealing with dynamically sized images and/or caching mechanisms that rely on URL params for cache expiration, so this might be something you want to consider for this extension.

Add image validation helper method

It would be used in the ACP and when extracting images from post description.

It throws warnings when open_basedir is set

\phpbb\filesystem\filesystem::resolve_path() (called from \phpbb\filesystem\filesystem::realpath()) throws the following warnings when calling is_link(), is_dir() or is_file() on the server root directory, which is usually excluded (for security reasons) from the open_basedir directive.

It doesn't seems to be a bug of this extension but from phpBB's filesystem class.

https://tracker.phpbb.com/browse/PHPBB3-15643

It generates incorrect Open Graph locale

Reference:

• https://www.phpbb.com/community/viewtopic.php?p=15279406#p15279406

The information about the current version could not be retrieved

As the title says, phpBB ADM cannot check for updates.

Add ACP option to enable/disable use of forum image

It should be up to the admin to enable this feature.

Related to #36 and #43

PHP Notice: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 126: Trying to access array offset on value of type null

I, in some page of my forum not all, i got this message :

[phpBB Debug] PHP Notice: in file [ROOT]/ext/alfredoramos/seometadata/event/listener.php on line 126: Trying to access array offset on value of type null

I use Phpbb3.3 and the latest version of your extension.

Disable metadata modification of default images

There's no reason the admin would need to modify the image width, height or MIME type.

Specific post-based metadata (direct links)

i was thinking that it would be cool to have an option for metadata derived from specific posts when a specific post is linked to.

so, for a url like this: https://www.example.com/viewtopic.php?t=20
the metadata is derived from the first post of topic 20. perfect.

however, for a url like this: https://www.example.com/viewtopic.php?t=20&p=101
this is a link referring to a specific post in that topic (post id 101).
it would be nice to have an option to enable deriving metadata from post 101 instead of the first post of topic 20.
which metadata?
use the overall topic title for title (same as the current behavior), but maybe derive the descriptions and image from the post in question (101 in this example).
and if there's no image in post 101, the fallback sequence would be: post 101 > first post of topic 20 > default overall site image

not a very important feature, but if you're looking for things to add, i think it would be cool.

https://www.phpbb.com/customise/db/extension/seo_metadata/support/topic/208701