Giter Site home page Giter Site logo

Comments (2)

Nemo157 avatar Nemo157 commented on June 7, 2024

Hmmm, actually, it may require some duplication because of the current behavior with invalid http::request::Builder's, I'd suggest in a future version switching to impl TryFrom<http::request::Builder> for ureq::Request and make invalid builders just return their error.

from ureq.

MarijnS95 avatar MarijnS95 commented on June 7, 2024

@Nemo157 I was just in need of this too for the oauth2 crate, and it was trivial enough to provide this implementation: #669

I came to the same conclusion that http::request::Builder should really have been implemented using TryFrom, instead of falsely providing some random default method/address for an errored Builder that does not provide any sensible values (because it is storing an Err!).

from ureq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.