aliceo2group/bookkeeping

O2 Bookkeeping project for the ALICE experiment at CERN

bookkeeping's Issues

Attached images not shown

See f.ex. https://ali-bookkeeping.cern.ch/api/attachments/1505?page=log-detail&id=38173. When clicking the attached images, the images simply fail to load. If I say "Open in new tab" (right-click context menu), then the images does show up. However, if I try to download the images from the new tab, then I get a network error. Perhaps a problem is that the files how no "extension" - i.e., the file name is 1506 not 1506.png. This makes it hard to communicate things since image attachements are not really useful. BTW, is there a way to include the image inline in the log entry? The url of the uploaded images gets all mangled so it is impossible to predict the correct URL.

ali-bookkeeping says "browser not supported"

When visiting https://ali-bookkeeping.cern.ch from Android with Chrome 102 the page says browser not supported, but the supported browsers says Chrome 88. Perhaps you are filtering on the OS too. Surely Chrome 102 on Android should work too. Thanks.

[O2B-546] Runs should have Edit button only for admins

In the Run-Details Page, top right corner, there is a group of 2 buttons

The Edit Run button should only be displayed to admins. The check can be validated via the method model.isAdmin()

Acceptance Criteria

• If the user is Admin, the group button should be displayed as it is now
• If the user is a non-admin user, a single button should be displayed instead Add Logs to this Run
• Tags should be added accordingly to validate the existence of button or not

[O2B-547] Update RUNS API request should check user permissions

Currently there is no check on updating a run on back-end. There should be one that checks if the user is admin or not

Acceptance Criteria:

• Similar to tags.controller, add a check for admin in the runs.controller for updating the RUN
• Add tests to validate the new behaviour;
• OpenAPI spec file should be updated accordingly;

e.g of a similar change to tags: https://github.com/AliceO2Group/Bookkeeping/pull/547/files#diff-dfce4d9d11a31be72739d767812e1b3435a06045c19be411a28b517d2c208001