Giter Site home page Giter Site logo

Comments (5)

alikaragoz avatar alikaragoz commented on July 22, 2024

Hi @stevewirig I will take a look at it in the weekend and keep you informed, we might have broken a few things down the road.

from mcswipetableviewcell.

stevewirig avatar stevewirig commented on July 22, 2024

Thanks @alikaragoz! Just to be clear, the Switch and Exit Modes ARE disabled, but IMO the swipe gesture recognizer from left to right should be disabled as well if both state1 and state2 are set to None.

from mcswipetableviewcell.

mtnbarreto avatar mtnbarreto commented on July 22, 2024

Hey @alikaragoz,
I've used the cell icons and colors in my pull request (#31) in order to disable the swipe. I didn't know the MCSwipeTableViewCellModeNone meaning.
Would you mind if I change my pull request in order to use MCSwipeTableViewCellModeNone instead?

from mcswipetableviewcell.

stevewirig avatar stevewirig commented on July 22, 2024

This is working for me.

        if (point.x > 0 && self.modeForState1 == MCSwipeTableViewCellModeNone && self.modeForState2 == MCSwipeTableViewCellModeNone){
            return NO;
        }
        if (point.x < 0 && self.modeForState3 == MCSwipeTableViewCellModeNone && self.modeForState4 == MCSwipeTableViewCellModeNone){
            return NO;
        } 

I cant think of any reason for the right swipe to be active if there are no actions on for those states, so this methodology makes sense to me.

from mcswipetableviewcell.

mtnbarreto avatar mtnbarreto commented on July 22, 2024

@stevewirig cool, Let's @alikaragoz check and approve the change and then I create another pull request using the modes instead of checking the existence of the icons and colors.

from mcswipetableviewcell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.