allpro/layout

jQuery UI Layout v1.x plugin

layout's Issues

Error due to incomplete if-else if-else statement

In commit af0863f of the https://github.com/GedMarc/layout fork, a bug is introduced at the if-else if-else that begins if (s.isClosed || s.isResizing) in slideClose in the jquery.layout_and_plugins. The syntax is wrong, because there is no statement after the if, and no open and close brackets in place of the statement that was removed.

Button Addon: inst.state[pane] is undefinined during _load() when called from layout()

When using jquery.layout 1.4.3, upon initial page load on Firefox 38.6 or later, the _load() method within the jquery.layout.buttons.js is caught by Firefox 38.6 with Firebug 2.0.19 as having an undefined 'inst.state[pane]'.

The 'pane' value is 'n' in my scenario and there isn't a code path from calling 'layout()' on the main jquery.layout which initializes the inst.state[pane] properly.

Note: Firefox + Firebug cause this where Chome and IE didn't.

inst.state[pane].pins = [];
File: jquery.layout-143_and_plugins.js
Line: 5886

1.4.4

The version in the repo is 1.4.3, whereas 1.4.4 is available from:
http://layout.jquery-dev.com/lib/js/jquery.layout-latest.js

Would be good if there was one dist folder instead of all the different versions.

how to use such as addToggleBtn function in latest version

outerLayout = $("body").layout( layoutSettings_Outer );
outerLayout.addToggleBtn( "#tbarToggleNorth", "north" );
var westSelector = "body > .ui-layout-west"; // outer-west pane
$("").addClass("pin-button").prependTo( westSelector );
outerLayout.addPinBtn( westSelector +" .pin-button", "west");
$("").attr("id", "west-closer" ).prependTo( westSelector );
outerLayout.addCloseBtn("#west-closer", "west");

maskContents bug

Hard to pin down, but I'm finding that when having maskContents enabled it sometimes blanks out one of my panes when it shouldn't. It seems to get inverted somehow as during resize the pane becomes unmasked.

Is there a reason why we can't just have one big transparent div over the entire screen which is created on dragstart and removed on dragstop? This approach seems to be working ok for me.

Cannot read property 'split' of undefined

i use jquery-3.1.1 and jquery-ui-1.12.1
i get this error :

VM1567:1832 Uncaught TypeError: Cannot read property 'split' of undefined

in this line (1392):

sC.selector = $N.selector.split(".slice")[0];

Dead "issues" link on http://layout.jquery-dev.com/

On http://layout.jquery-dev.com/ under "Contact information" I see:

Review issues and requests on the issues page page

That link - to http://layout.jquery-dev.com/issues.html - should be changed to https://github.com/allpro/layout/issues, right?

Also, the http://layout.jquery-dev.com/issues.html page is not entirely dead, but opens a frame with src="http://archive.plugins.jquery.com/project/issues/Layout#jq-content" and that gets a "Server not Found". Perhaps http://layout.jquery-dev.com/issues.html should also be changed to point to https://github.com/allpro/layout/issues.

jQuery 3 compatibility issue

This line breaks jQuery 3 support, seems to work fine without it:
https://github.com/allpro/layout/blob/master/source/stable/jquery.layout.js#L1832

Also .bind / .unbind are deprecated.

Publish this project on NPM

Hey, @allpro.

We use npm as our package manager. Right now we have to use Napa to install jquery-ui-layout but, this process is flacky and would be so much easier and reliable to use directly from npm repository. Do you have plans to publish jquery-ui-layout as an npm package?

Support for using layout as a bower component.

This way there is no need to check in the layout code in other repositories and makes it much easier to detect updates.

JQuery 3.x $.parseJson

$.parseJson is now JSON.parse in JQuery 3.x

https://github.com/jquery/jquery-migrate/blob/master/warnings.md

JQMIGRATE: jQuery.parseJSON is deprecated; use JSON.parse

Cause: The jQuery.parseJSON method in recent jQuery is identical to the native JSON.parse. As of jQuery 3.0 jQuery.parseJSON is deprecated.

Solution: Replace any use of jQuery.parseJSON with JSON.parse.

Child Panes in Nested Layouts not respecting ToolTip Defaults

I have an example page here: http://www.primefaces.org/showcase-ext/sections/layout/fullPageAttr.jsf

I have set the default option of togglerTip_closed = "Close Me". If hove over the close on the outside panes you see the tooltip is "Close Me", however if you hover over any of the internal panes like West North or West-South you see it has the default "Close".

When using within an iframe with 3rd party cookies blocked, "No suitable storage found" error thrown

I've been using the layout manager for several years.

More recently, we upgraded to the latest NPM download for layout-jquery3.

When using it within an iframe to publish a page on domain other than the page domain, we get a 'No suitable storage found' error, when the user's browser has blocked all 3rd party cookies.

I'm willing to dig into the code to fix, but would need some guidance.

jQuery.fn.bind() is deprecated

jQuery.fn.bind() is deprecated

for (name in layoutMethods) {
    $N.bind("layout" + name.toLowerCase() + "." + sID, Instance[ layoutMethods[name] || name ]);

Change to $N.on(...) and adjust syntax if needed.

project dead?

Is this project dead because it seems pretty inactive.
If so I may make a fork.