almariah/k8s-metadata-injector

Inject metadata into kubernetes resources based on namespces

k8s-metadata-injector's Issues

After following the installation instructions I get the following error

`W0313 23:37:52.177907 1 client_config.go:549] Neither --kubeconfig nor --master was specified. Using the inClusterConfig. This might not work.
I0313 23:37:52.185843 1 controller.go:99] Starting ebs-tagger controller
I0313 23:37:52.185903 1 controller.go:106] Waiting for informer caches to sync
I0313 23:37:52.386264 1 controller.go:114] Starting workers
I0313 23:37:52.386357 1 controller.go:120] Started workers
E0313 23:37:52.386514 1 runtime.go:69] Observed a panic: "index out of range" (runtime error: index out of range)
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/runtime/runtime.go:76
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/Cellar/go/1.11.4/libexec/src/runtime/asm_amd64.s:522
/usr/local/Cellar/go/1.11.4/libexec/src/runtime/panic.go:513
/usr/local/Cellar/go/1.11.4/libexec/src/runtime/panic.go:44
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:179
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:145
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:131
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:117
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/usr/local/Cellar/go/1.11.4/libexec/src/runtime/asm_amd64.s:1333
panic: runtime error: index out of range [recovered]
panic: runtime error: index out of range

goroutine 44 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/runtime/runtime.go:58 +0x108
panic(0x13eaa40, 0x23af9b0)
/usr/local/Cellar/go/1.11.4/libexec/src/runtime/panic.go:513 +0x1b9
main.(*Controller).process(0xc00026ff00, 0xc00048c074, 0x7, 0x15b47ce, 0x6, 0x0, 0x38)
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:179 +0x5e2
main.(*Controller).processNext(0xc00026ff00, 0xc00033d400)
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:145 +0xff
main.(*Controller).runWorker(0xc00026ff00)
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:131 +0x2b
main.(*Controller).runWorker-fm()
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:117 +0x2a
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc000477b20)
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/wait/wait.go:133 +0x54
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc000477b20, 0x3b9aca00, 0x0, 0x1, 0xc00007c660)
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/wait/wait.go:134 +0xbe
k8s.io/apimachinery/pkg/util/wait.Until(0xc000477b20, 0x3b9aca00, 0xc00007c660)
/Users/abdullah/go/src/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x4d
created by main.(*Controller).Run
/Users/abdullah/Sandbox/kub/k8s-metadata-injector/controller.go:117 +0x343
`

how do I configure the region for volume tagging?

E1003 18:16:34.128974 1 controller.go:172] Error processing {pvc-XXXXXXXXXX CREATE} (giving up): failed to create ebs tags: MissingRegion: could not find region configuration

Broken Image v1.0.0

The v1.0.0 image appears to have been rebuilt 2 days ago and no longer works with existing k8s manifests. Can you please revert the image to its original state and increment the version # if that is the intent.

Enhancement: Add fall through / wildcard for metadataconfig.yaml

It would be really great if one didnt have to add a new entry into the configmap/yaml file every time a new namespace is added to the cluster. We have a collection of tags we want added to every service and ebs by default cluster wide.

ie something like:

    service:
      default:
        annotations:
          service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags: "foo=bar"
      *:
        annotations:
          service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags: "dog=canine"

Please update alpine base image

The current base image is alpine 3.9.4. This image has multiple critical CVEs in it which have since been fixed in newer versions. The latest alpine which is currently critical CVE free is 3.14.2. Though 3.15.0 is out, it does contain CVEs which have already been fixed in 3.14.2.

Thanks!

LoadBalancer Tags

Hey,

any plans for tagging LoadBalancer resources on AWS?

Greeting,
Lukas

How do I configure this to just annotate a stateful sets pvc?

How do I configure this for just one stateful set in a namespace foo?

Need support for dry-run

the k8s-metadata-injector is causing issues with the kubectl diff functionality.

> k diff -f manifest.yaml
Error from server (InternalError): Internal error occurred: admission webhook "serve.k8s-metadata-injector.io" does not support dry run

The manifest in question is a rendered helm chart of logstash. This is in effect a manifest that has not been applied yet containing a Service.