alpaker/frame-bufs

An Emacs minor mode for frame-relative buffer lists.

frame-bufs's Issues

Update documentation to provide a workound for current versions of Emacs.

The workaround to use Frame-Bufs with a current version of Emacs is as follows: obtain source for Emacs; remove contents of buff-menu.el (so that it doesn't get hard-wired into the executable during the build); build the application; obtain an older version of buff-menu.el that works with Frame-Bufs (tell users about specific Emacs version numbers that work with Frame-Bufs and provide a link to the download); put a provide statement at the bottom of the old version of buff-menu.el (place it in the load path) and then require it when loading Emacs.

[patch] emacs 23 (and 22) compatibility

Some of the machines I use emacs on only have version 23, and running the latest frame-bufs version there caused "Wrong type argument: window-live-p, nil" errors all over the place.

I fixed it by revising my fix for #2, simply replacing nil with (selected-window) on line 538.

Just for fun I tested that version with the emacs 22.1.1 shipped with OS X, and it even worked there.

diff --git a/frame-bufs.el b/frame-bufs.el
index 43dcd9a..ebb57f1 100644
--- a/frame-bufs.el
+++ b/frame-bufs.el
@@ -180,8 +180,8 @@

 ;;; Code:

-(when (< emacs-major-version 24)
-  (error "Frame-Bufs requires version 24 or later"))
+(when (< emacs-major-version 22)
+  (error "Frame-Bufs requires version 22 or later"))

 ;;; ---------------------------------------------------------------------
 ;;; User Options
@@ -535,7 +535,7 @@ variables `frame-bufs-associated-buffer-bit', `frame-bufs-use-buffer-predicate',
 ;;; ---------------------------------------------------------------------

 (defadvice select-window (after frame-bufs)
-  (frame-bufs--add-buffer (window-buffer) (window-frame nil)))
+  (frame-bufs--add-buffer (window-buffer) (window-frame (selected-window))))

 ;; Called by window-configuration-change-hook to update the associated-buffer
 ;; list.

Question: Frame-bufs operation with pop-up frames.

From the commentary section of frame-bufs.el
;; It is not
;; compatible with non-nil values of `pop-up-frames'.

I use the icicles library one-on-one which provides a frame oriented user experience, along with a stand alone mini buffer and sets pop-up-frames to t.

What issues are caused by setting non-nil values of pop-up frames?

Thanks
Mike

Wrong number of arguments: window-frame, 0

Enabling frame-bufs in emacs 24.3.1 on OSX resulted in the above error message on startup and when trying to complete a buffer name.

Adding a nil argument to window-frame in the defadvice on line 538 seems to have solved the problem.