alphagov/forms-admin

Repository for the GOV.UK Forms admin application

forms-admin's Issues

Make confirmation/what happens next page user-customisable

Align form title edit with prototype

We currently have the form edit title screen, but it should be aligned with the prototype

Create page for adding a question to a form

We should be able to add a question page to the form. The page itself could be made ahead of the API work, however the page itself will not be able to be persisted until that work has been completed

• form builder can add the question text
• form builder can add the optional short name
• form builder can optionally add hint text
• form builder can select the sort of answer it is from list:
  • single line of text
  • address
  • date
  • email address
  • National Insurance number
  • phone number
• user can save this page
• saves the question type as appropriate in the saved from structure

---

Related issues
alphagov/forms-api#25

favicon.ico is referenced but doesn't exist

forms-admin/app/views/layouts/application.html.erb

Line 13 in 095d24b

<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/assets/images/favicon.ico" type="image/x-icon">

Add CONTRIBUTING.md

We're unlikely to get any contributions from members of the public at this early stage, but it's probably a good idea to have a CONTRIBUTING.md in place early. At a minimum this should include a link to the Code of Conduct.

We may want to adapt one of the existing versions, e.g. the govuk-frontend CONTRIBUTING.md

Align form creation with the prototype

Related trello card: https://trello.com/c/BnBhH6gI/239-i-need-to-create-a-new-form

To do:

• Update new form screen to match the prototype
  • Note: We can keep the email here for now as well as we dont have a space for that in the prototype yet
• Redirect to form overview screen on creation (Depends on #43)
• Journey covered in automated tests
  • Note: These should include request specs and front end tests using cypress

Update Edit question page to align with design

https://trello.com/c/ut4hFA9P/428-update-edit-question-page

• Hide short name
• Change hint text heading
• Update buttons content and style
• 'Go to form overview' is a separate link

Form builder can edit their form title

Users can change the name of a form to match the prototype.

https://trello.com/c/ju45ouWT/263-form-builder-can-edit-their-form-title

Add sentry

We want to use sentry for exception tracking, we will need to set up a sentry account and ensure the service can send exceptions correctly

Add a beta phase banner

https://design-system.service.gov.uk/components/phase-banner/

Localise existing views

We recently added localisation to the repo (#56) and from this point on we will be localising any new views or components we create. However, there are existing views which still have hard-coded English text in them.

We should complete this issue before we start adding support for other languages.

This affects:
forms/

• edit.html.erb
• new.html.erb
• not_found.html.erb
• show.html.erb

home/

• index.html.erb

layouts/

• application.html.erb

Add CODEOWNERS file

From the GDS Way:

Consider protecting the .github/workflows folder by using a CODEOWNERS file and requiring review from CODEOWNERS for merges into protected branches.

End-to-end Spike: Admin API integration

Setup models/controllers for connecting to the API where required

• Create a new form
• List the forms (optional)

Allow user to delete pages / questions

Configure Sentry SDK with govuk-forms org DSN

Create initial form overview screen

Both #41 and #42 require a form overview screen to link to, we can create a simple one to begin with that contains an edit link to our existing edit page (editing the title/submission email)

As this will be iterated and changed in the future, we don't need to worry about making this too designed and can just be a simple link to the edit details page that exists already

To do

• Create form overview screen
• Form overview screen contains link to existing edit screen for "Edit form"

End-to-end form spike: Admin UI

• Forms list
• Form create page

Part of Spike: Allow user to create a form with a title that sends email to GOV.UK Notify

Align create form journey with with prototype

Tasks

• Use a Start button for the create a form button on the homepage, instead of a normal button
• Make the label for the respective form name and email pages use h1 elements
• Separate the email address question from the form name question, and don't include it in the create a form journey
• Make the form name and email pages 2/3 width
• Set the submission email to an empty string when the form is created

Trello cards:

https://trello.com/c/DzXscuZj/426-landing-page-forms-as-a-start-button
https://trello.com/c/0PVwvL3k/427-create-a-form-journey-update

Add friendly Error pages

This should include:
404 for page not found
500 for unexpected errors
Service unavailable (in case we need to take the service down temporarily)

Switch to RSpec

Add PR Template

Add Cypress tests to CI pipeline

We should run the Cypress tests on every PR to to catch any issues early. Ideally we should add this to our existing CI workflow.

Add code coverage to form-admin (https://github.com/alphagov/forms/discussions/38)

As a result of alphagov/forms#38 discussion

• Add simplecov to record coverage
• Setup sonarcloud to link to this repo
• New PR get a report of coverage and any smells

Update README to use the GDS template

GDS has a standardised README format. We should use this in our repositories.

500 response code returned for 404 condition

forms-admin is returning a 500 http response code in situations when a 404 would be expected, e.g.

{ADMIN_BASE}/this-should-return-a-404

Align form builder home screen with the prototype

Trello card: https://trello.com/c/2mA8sYr5/262-create-form-builder-home-screen

Prototype screen: https://forms-prototypes.london.cloudapps.digital/form-designer/form-home

To do:

• Update form home screen create button to match the prototype
• Update form list display to match the prototype
  • Note: In Dev we can keep the link to the runner for now as a link underneath the form name or something similar
• Edit links take you to the form overview screen (depends on #43 )
• Create request and frontend specs for this

Configure frontend build

This should include anything we're likely to need in both forms-admin and forms-runner, but not anything more specific. We already have a default Rollup build but this may also need a but of configuring.

This should include:

• babel for transpiling
• a browserslist configuration (start with a sensible default, we will adjust this later once we have a better idea of our user stats)
• jest for unit testing
• cypress for end-to-end testing
• style and js linting
• autoprefixer
• dart-sass instead of ruby-sass
• install govuk-frontend
• style and js formatting

Configure Github actions PR workflow

We want a github action to run against every pull request, this should include:

• Running the tests
• Monitoring test coverage
• Running linting

End to end form spike: Signon Integration

We want to integrate with Signon for authentication during our private beta

This will likely use the GDS SSO Gem

Display questions on form overview screen

• When I follow a link from the home screen it opens the form overview screen for that form
• This screen displays the form name, a create question button
• includes a link to allow user to edit the form name
• include a link to allow the user to edit each question that's been added

Fix asset rendering bug

Currently the govuk-frontend assets (most noticeably the GDS Transport font) aren't being compiled by the asset build. This means that the fonts and assets will load correctly on a local machine, but return 404s on the dev server.

Order list of forms sensibly

Alphabetical until we surface the updated_at field