alreadybored/basic-js-ds

basic-js-ds's Issues

Incorrect binary search tree picture

According to the structure of a Binary search tree the right node is supposed to have a greater value than the parent one, so in this case the node must have a value greater than 5.

Here's the picture for replacement

update tests for "Remove from list test cases" task

Would you mind to add some additional test cases to the Remove from list task:

• list with double k value (for example: initial [1, 2, 3, 3, 4, 5], expected [1, 2, 4, 5])

• list with k at the end (for example: initial [1, 2, 3], expected [1, 2] )

Presence of Obfuscated and Minified JavaScript Files in Test Suite Poses Security Risk And Loss of User Data

Hello there,

I hope this message finds you well. I am writing to bring your attention to a critical issue identified in the test suite of the basic-js-ds GitHub repository. The concern revolves around the presence of obfuscated and minified JavaScript files within the test suite, for which no corresponding source code is available.

Issue Description:
The current state of the test suite includes JavaScript files that have been obfuscated and minified, making it impossible to review and rebuild the code to confirm its content. This lack of transparency raises serious security concerns, as it introduces the risk of potential malicious code that could compromise the integrity of the repository and, consequently, the security of user data.

Potential Implications:
Security Risk: The obfuscated code may contain malicious elements that could compromise the security of the entire repository and, consequently, user data.

Inability to Verify Code:
Without access to the source code, it is challenging to verify the legitimacy and security of the obfuscated and minified files.

Proposed Possible Actions:

1. Remove files with obfuscation
2. Add description into README
   Unfortunately similar proposition was met harshly at RSSchool and was closed upon opening PR: rolling-scopes-school/core-js-conditions-n-loops-tasks#18
3. Introduce running test in a Docker container, this way if a person doesn't trust obfuscation, they can run the tests in a isolated container. Similar to following:
   https://github.com/vetalapo/rsschool-projects/blob/main/basic-js-ds/Dockerfile