alter-ego/androidbound

Two-way binding library for Android

androidbound's Issues

add lifecycle methods to the ViewModel

• onCreate
• onPause
• onResume
• onSaveInstanceState

Add tests

add support for multiple objects/layouts to ListView

It would enable us to use lists with different types of objects, each of which would inflate a different layout.

in binding activities, check ViewModel.onCreate() lifecycle

Should it be called from the activity onCreate() or onPostCreate(), when the activity is already initialized (similar to fragment lifecycle)?

@hamen opinions?

Make Iterables.remove() more functional

Add ViewPager binding support

Add DiffUtil support to RecyclerView adapter

• https://developer.android.com/reference/android/support/v7/util/DiffUtil.html
• https://medium.com/@nullthemall/diffutil-is-a-must-797502bc1149#.sxaor1nb2
• https://github.com/mrmike/DiffUtil-sample

Add multiple ViewModels support to Binding Activities/Fragments

Add RecyclerView support

add placeholder option/converter for ImageView

Fix problem with AppCompatActivity in support libraries > 22.0.0

Binder doesn't get called at all in newer support libraries.

Binding activites should dispose of internal ViewModels in onDestroy

by calling viewmodel.dispose(), it will then remove the ViewModel's internal activity reference.

Binder checks type when binding through ValueConverter

When binding using ValueConverter - like binding="{Text @= LocalizedFullName(Profile)}", the binder still checks types when binding and complains that object Profile cannot be cast to String required by the method Text:

Error occurred while binding Profile to target Text: org.sharethemeal.app.user.models.Friend$FriendProfile cannot be cast to java.lang.String

add missing bound properties to widgets

there's some stuff still missing - for example, Button doesn't have bindable TextColor or Color.

add set/getFontManager to IViewBinder interface

it should be pulled from ViewBinder instance into the interface.

bound data inside Binding activities should be a ViewModel and not an Object

Fix example (doesn't use binding)

needed examples:

Activities

• normal activity
• bindable activity

UI

• textview
• button
• edittext
• listview
• image
• layout

Binding commands

• text
• click
• font
• visibility
• long click
• resource
• source
• items source
• text color
• background color
• text string (edittext)

Custom stuff

• value converter

Offer other image loaders beside Universal Image Loader

Migrate to Kotlin

Rename Iterable where operator to filter

That way it will be more in line with RxJava names

allow ValueConverter parameters without ''

currently ValueConverter only interprets parameters inside '', which means that

binding="{Text @= LocalizedFullName(Profile.Firstname, 'Profile.Lastname')}"

sees the parameter, but

binding="{Text @= LocalizedFullName(Profile.Firstname, Profile.Lastname)}"

doesn't, which doesn't allow us to bind to objects as parameters.

Replace reflection with generated code

Evaluate if this could actually be done... and do it.

Add CircleCI

replace "<" and ">" with "@" in binding commands

viewbinding doesn't work on android 4.4

presumably on all versions 11 < x < 21, it's a bug regarding the support libraries. There's a code in the android.support.v4.view.LayoutInflaterCompatHC that helps.

BindableAcitivities delete all bindings when destroyed

If the call happens too late - as it does with Android, you can actually have two activities open at the same time - then it will also delete binding of other activities. It should just delete the calling activity's parent view bindings.

remove unnecessary this from widgets

add viewholder to BindableListViewAdapter?

should we? can we?

Parsing null specs shouldn't crash

when parsing binding strings likebinding="{SourceUri @= OptimizedImageUrl(Achievement.ImageUrl, '70, 1.0, png, 80, fill')}}", that extraneous } at the end will confuse the parser and he will try to parse the spec which is null.

here's the (incomplete) stacktrace:

09-06 11:59:37.731: E/AndroidRuntime(17922): FATAL EXCEPTION: main
09-06 11:59:37.731: E/AndroidRuntime(17922): Process: org.sharethemeal.app.android, PID: 17922
09-06 11:59:37.731: E/AndroidRuntime(17922): java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String[] java.lang.String.split(java.lang.String)' on a null object reference
09-06 11:59:37.731: E/AndroidRuntime(17922):    at solutions.alterego.androidbound.factories.SourceBindingFactory.create(SourceBindingFactory.java:23)
09-06 11:59:37.731: E/AndroidRuntime(17922):    at solutions.alterego.androidbound.binding.BindingAssociationEngine.createTargetBinding(BindingAssociationEngine.java:106)
09-06 11:59:37.731: E/AndroidRuntime(17922):    at solutions.alterego.androidbound.binding.BindingAssociationEngine.<init>(BindingAssociationEngine.java:47)
09-06 11:59:37.731: E/AndroidRuntime(17922):    at solutions.alterego.androidbound.binding.TextSpecificationBinder.bind(TextSpecificationBinder.java:49)
09-06 11:59:37.731: E/AndroidRuntime(17922):    at solutions.alterego.androidbound.ViewBinder.bindViewToSource(ViewBinder.java:197)
09-06 11:59:37.731: E/AndroidRuntime(17922):    at solutions.alterego.androidbound.ViewBinder.checkAndBindView(ViewBinder.java:187)
09-06 11:59:37.731: E/AndroidRuntime(17922):    at 

NPE in ViewModel.dispose()

05-22 15:51:47.779: E/AndroidRuntime(9493): Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void rx.subjects.PublishSubject.onCompleted()' on a null object reference
05-22 15:51:47.779: E/AndroidRuntime(9493):     at solutions.alterego.androidbound.ViewModel.dispose(ViewModel.java:42)
05-22 15:51:47.779: E/AndroidRuntime(9493):     at solutions.alterego.androidbound.android.BindingAppCompatActivity.onDestroy(BindingAppCompatActivity.java:40)
05-22 15:51:47.779: E/AndroidRuntime(9493):     at org.sharethemeal.app.core.BaseBindingActivity.onDestroy(BaseBindingActivity.java:137)

check Image Source binding, it doesn't seem to work!

remove JodaTime dependency

library cleanup

some small tasks that should be done:

• add namespaces for attributes
• fix missing styling support in view constructors - test
• check implements INotifyPropertyChanged usage - is it necessary?

replace simple getters/setters with Lombok

add header/footer support to ListView/GridView

binder doesn't see inherited methods/properties?

If you try to bind to one of the inherited methods/properties of the object, it won't work. It seems that it doesn't work even if you add the corresponding property getter method to the object.

example:

public class Original {
    public DateTime date;
}

public class OriginalChild extends Original {
    public DateTime getDate();
}

binding to date won't work!

Refactor BindingMode from enum to int

Add design support library compatibility

Remove superfluous views

Add int to ColorStateList converter

needed for TextView.setTextColor(int)

add loadable interface?

@hamen ?

add support for view animators

Add tint to ImageView

Remove double casts from ViewBinder

remove unnecessary BindingApplication

As it is, it's not useful at all.

Add quick guide to README

add detailed wiki

we need the following:

• binding types list with explanations
• supported widgets list, with supported bindings
• lifecycle guide
• value converter guide
• font manager
• debugging guide

fix canX method not prevending doX method from execution

add advanced wiki pages

• object binding reference (internal objects, lists etc.)
• create bindable views

BindingSpecificationParser fails if the group is closed twice

If the binding finishes with double }} the BindingSpecificationParser will call parseMode with null string, and it will then crash:

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
                                                       at solutions.alterego.androidbound.parsers.BindingSpecificationParser.parseMode(BindingSpecificationParser.java:122)
                                                       at solutions.alterego.androidbound.parsers.BindingSpecificationParser.parse(BindingSpecificationParser.java:107)
                                                       at solutions.alterego.androidbound.parsers.BindingSpecificationParser.parse(BindingSpecificationParser.java:16)
                                                       at solutions.alterego.androidbound.parsers.BindingSpecificationListParser.parse(BindingSpecificationListParser.java:52)
                                                       at solutions.alterego.androidbound.parsers.BindingSpecificationListParser.parse(BindingSpecificationListParser.java:11)
                                                       at solutions.alterego.androidbound.binders.TextSpecificationBinder.bind(TextSpecificationBinder.java:41)
                                                       at solutions.alterego.androidbound.android.BindableLayoutInflaterFactory$InflaterFactoryBase.bindView(BindableLayoutInflaterFactory.java:107)
                                                       at solutions.alterego.androidbound.android.BindableLayoutInflaterFactory$2.onCreateView(BindableLayoutInflaterFactory.java:64)
                                                       at android.view.LayoutInflater$FactoryMerger.onCreateView(LayoutInflater.java:171)
                                                       at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:727)
                                                       at android.view.LayoutInflater.rInflate(LayoutInflater.java:806) 
                                                       at android.view.LayoutInflater.inflate(LayoutInflater.java:504) 
                                                       at android.view.LayoutInflater.inflate(LayoutInflater.java:414) 
                                                       at android.view.LayoutInflater.inflate(LayoutInflater.java:365) 
                                                       at solutions.alterego.androidbound.ViewBinder.inflate(ViewBinder.java:193) 
                                                       at solutions.alterego.androidbound.example.MainActivity.onCreate(MainActivity.java:27)