Comments (7)
Could you explain in more details what the issue is please? What kind of problems occur with @Async
and @Locked
?
from distributed-lock.
He will cause the lock to be implemented first, and then to enable asynchronous threads.
This will invalidate the lock.
| +-------------------------------------------+
| | Lock:Thread-1 |
| | +-----------------------------------+ |
| | | Async:Thread-2 | |
| | | +----------------------------+ | |
| | | | method:Thread-2 | | |
| | | +----------------------------+ | |
| | +-----------------------------------+ |
| +-------------------------------------------+
↓
from distributed-lock.
Sorry for the late reply. You can extract the logic to be locked in a new service and annotate that method using @RedisLocked
instead. That behaviour is pretty similar to @Transactional
behaviour to control transactional logic so I am not sure this requires any changes since it can be mitigated.
from distributed-lock.
Currently, I have changed the Order value of LockBeanPostProcessor
so that it can work before AsyncAnnotationBeanPostProcessor
, This solution works.
Like this
@Bean
public LockBeanPostProcessor lockBeanPostProcessor(
final ConfigurableBeanFactory configurableBeanFactory,
final KeyGenerator keyGenerator,
@Autowired(required = false) final TaskScheduler taskScheduler) {
LockBeanPostProcessor lockBeanPostProcessor = new LockBeanPostProcessor(new BeanFactoryAwareIntervalConverter(configurableBeanFactory), configurableBeanFactory::getBean, keyGenerator, taskScheduler);
lockBeanPostProcessor.setOrder(Ordered.LOWEST_PRECEDENCE - 10);
return lockBeanPostProcessor;
}
But this method is not elegant enough, it is best to set LockBeanPostProcessor
according to whether there is Transactional
or Async
from distributed-lock.
I understand your point, but I think you already noticed yourself that it won't really be possible to get the right order for each application. According to a comment here: Spring project's aspects do not have advice ordering guaranteed. And this is the same argument I am making.
How about something like this:
@Autowired
private LockedService lockedService;
@EventListener
@Async
public void sendEmail(XXXEvent event) {
lockedService.sendEmail(event);
}
class LockedService {
@RedisLocked
public void sendEmail(XXXEvent event) {
}
}
from distributed-lock.
Thank you, your solution is better, but users need to pay attention to the order of aspects.
Expect Spring to provide a more systematic solution.😂
from distributed-lock.
I think we reached an acceptable conclusion so I am going to close this issue for now.
from distributed-lock.
Related Issues (20)
- Allow re-entrant code within same Thread? HOT 9
- Need a help HOT 13
- `scriptExecutor` of `RedisTempate` is null HOT 1
- JDBC lock is not working with MySql due to wrong SQL syntax
- JDBC lock not working with PSQL due to SQL syntax HOT 9
- MongoLocked: Don't retry on "fail to acquire" HOT 2
- Cant create a table with reserved name 'lock' for jdbclock as HOT 1
- Need a hand :) ! HOT 3
- Null lock token versus LockNotAvailableException HOT 4
- "RetriableLock should return null if lock is not acquired after the last retry" - ok.. but why? HOT 2
- RedisLock throws RedisReadOnlyException when using RedisStaticMasterReplicaConfiguration and ReadFrom.REPLICA_PREFERRED HOT 2
- Importing the whole library causes auto wiring issues in Spring Boot HOT 5
- Does it Support Spring Boot 3 ? HOT 7
- Getting Started HOT 2
- Option not to throw exception on lock fail HOT 1
- JDBC Manual Controlled Lock HOT 4
- Testing Annotated Locks HOT 8
- What is the reason behind only using JitPack? HOT 1
- About throwing option added in recent PR HOT 1
- Wrong documentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from distributed-lock.