alviner/dnslib3

dnslib3's Issues

Forking dnslib

Hi @mosquito, @Alviner,

I've noticed a few pull requests against paulc/dnslib which appear to be originating from this repository.

Before continuing, you might want to take a look at my PR paulc/dnslib#61 where I did a lot of work to update dnslib to python 3.

In addition it looks like the original author (paulc) would prefer to have dnslib forked rather than continue under it's current name: paulc/dnslib#61 (comment)

Depending on your intentions it might be worth starting a discussion with paulc if you did want to continue to maintain an updated dns lib into the future. In this regard I would be happy to contribute the code in that PR to teh cause, and may be able to help maintain it (though do not have the time to do heaps of feature work at the moment).

That said per my comment on that PR, unless you /really/ want to use dnslib, it might be better to focus efforts on the much more active dnspython rather than having 2 communities attempting the same thing.

DNS SRV "target" names are compressed

DNS SRV RR should not be compressed.

From RFC2782, page 3:

Target
The domain name of the target host. There MUST be one or more address records for this name, the name MUST NOT be an alias (in the sense of RFC 1034 or RFC 2181). Implementors are urged, but not required, to return the address record(s) in the Additional Data section. Unless and until permitted by future standards action, name compression is not to be used for this field.

The correction is at line 1684 of dns.py:
buffer.encode_name_nocompress(self.target)

and, for completion, to comment at line 303 of label.py:
(needed for RRSIG, SRV)

There are probably RR that mustn't use name compression - I haven't yet scoured the specs

Thank you for your efforts on this project.