amazon-archives/sql-odbc

Open Distro for Elasticsearch ODBC Driver

sql-odbc's Issues

Add fetch_size for pagination support

Can't connect to server

I cannot connect to server.

Server version: Opendistro 1.7.0
ODBC client version: 0.2.0

Error: Failed to Establish Connection to DB

Windows: Windows Server 2012R2

fix example tdc file

Fix linking issue on mac installer

Add endpoint info and performance results to test output

Add test to collect endpoint info and extend python parse to put the endpoint info into the test output
Also add performance results to test output

Link version of installer to version of driver

Add support for building Mac installers

Should build productbuild package for automatic installation, as well as a tarball archive for more custom installations.

Fix General installer components

• Add TDC to installer package
• Update Driver as required component in installer
• Change the binary & project name

Fix log output directory

The log output directory is not changed after setting the log path in

• DSN
• Connection String

Use a queue which is created with a capacity while getting result pages

ref: https://github.com/opendistro-for-elasticsearch/sql-odbc/pull/101/files#r432291911

Add automatic checks for Cppcheck during Actions builds

We want to make sure that quality code is being submitted, so having automatic static code analysis on every PR build will help ensure this level of quality.

Update test to check driver version

mac-installer 1.7 failure

Are there any known problems with mac-installer v1.7.0.0?

My installation attempt on MacOS Catalina v10.15.4 fails, and I'm seeing the following in logs:
installd[1725]: PackageKit: Executing script "./postinstall" in /private/tmp/PKInstallSandbox.u8xo7K/Scripts/com.Amazon.ODFE SQL ODBC Driver.Driver.7qOYqn
installd[1725]: ./postinstall: dyld: Library not loaded: @rpath/libodfesqlodbc.dylib
installd[1725]: ./postinstall: Referenced from: /usr/local/lib/odfe-sql-odbc/bin/dsn_installer
installd[1725]: ./postinstall: Reason: image not found
installd[1725]: ./postinstall: /tmp/PKInstallSandbox.u8xo7K/Scripts/com.Amazon.ODFE SQL ODBC Driver.Driver.7qOYqn/postinstall: line 14: 27143 Abort trap: 6 ${FINAL_INSTALL_DIR}/bin/dsn_installer ${FINAL_INSTALL_DIR}/bin/ > /tmp/dsn_installer.log

...
Install Failed: Error Domain=PKInstallErrorDomain Code=112 "An error occurred while running scripts from the package “ODFE SQL ODBC Driver-0.2.0-Darwin.pkg”

Add pagination support design document

Add log levels to driver logging

Add log levels to driver logger, and propagate log levels throughout calls to the logger in code.

Add postinstall step for configuring DSN and Driver on Mac

Windows installers make this easy with WiX and the registry, but we need a separate program to interact with the ODBC installer API to properly configure this on Mac.

Update documentation

Update documentation with references to github and also add THIRD-PARTY document.

Fix build instructions link in README.md

Extract fails while using tableau connector

Add resources in postinstall

Mac installer fixes

Found a couple of issues during final testing of installers

• No uninstall step
• Cannot link to driver dependencies due to rpath configuration

Apply branding choices to installers

Once internal discussion has finished, branding choices will need to be applied to the installers & verified.

Add pagination support

Update DSN setup UI

Test encryption & AWS authentication with Tableau on Mac

Driver performance improvements

Work on driver performance improvements around query execution flow.

I have identified some areas that can be optimized to do some initial performance improvements.

Fix error: Memory leak: our_connect_string

Add support for testing with code coverage

Add performance test for query execution

• Don't include google test.

Create Simple Windows Installer

Create a simple Windows installer that simply installs the binary dependencies (registry setup and proper versioning not required yet)

Connection string option tweaking

We should align our connection string options with ODBC default names for out outward options. This will allow tableau to properly populate the dialog boxes.

Furthermore, we should add a default drivername. I am not sure if it is considered a bug in Tableau, but if you default an empty string, Tableau will connect with the driver properly, then spin infinitely in the driver manager until forcefully killed, execution SQL calls in a loop, attempting to find a DSN with an empty string name. Regardless of whether it is a Tableau issue, let's add a default drivername.

Align connection tests with rest of test suite

Since the connection tests were our first set of tests, there are some methods for execution that should now be aligned with the rest of the tests available in our test suite.

Make sure ODBC functions are correctly supported

Based on the functionality offered by ODFE & the SQL plugin

Remove unnecessary aws sdk files from installers

• Remove all cmake files
• Remove all header files

Move TODOs over to GitHub issue numbers

Update tableau connector files

• Add connector for development purpose
• Add packaged connector

Connection sting abbreviation support

The current connection string options match the sql-jdbc driver.

ODBC Drivers very often use 'server' instead of 'host', 'UID' instead of 'user', and 'PWD' instead of 'password' in connection strings.

Adding support for this would be beneficial for users who are used to ODBC style connection strings. We can still leave our registry writing and registry files using 'host', 'user', and 'password'.

Connection string refactoring and registry updates

Remove unused connection string options, match current options with jdbc, and update registry.

Update README for authentication and encryption configuration options

Now that we can configure authentication and encryption, we should make sure our documentation for these options and others is up-to-date.

Setup GitHub actions to build driver for Mac and Windows

Get GitHub actions up to build driver for Mac and Windows.

Tests will not run initially. They will be setup so that they can just be uncommented and will run and make result artifacts in the future. We need the ability to deploy a server to send our queries to before we get our testing setup.

Ensure Keyset's are reported as not supported by cursor attributes

Ensure that calls to SQLGetInfo report that keysets are not supported

Implement SQL integration for Microsoft Excel

Open Distro support for ODBC Driver in Excel with the M connector

Add Tableau connector

• UI elements needed to collect user input for creating a connection to a data source
• dialect and customizations needed for the connection

Add support for building driver for 32-bit applications

Mac installer fails if driver files already exist

Update catalog tests to not require specific set of tables

Currently, the SQLTables catalog integration tests expect a specific set of data tables loaded into the ODFE server in order to pass. (if there are any missing, or any unexpected tables, some tests fail)

This check should be changed so it checks for a set of required tables on the server, but not failing for extra tables existing.

Update build instructions for aws sdk setup

• add script for sdk setup
• update build instructions

Update windows installer

• Add registry setup
• Add icon
• Add documentation

Remove gtest & gmock files from installers

Address Cppcheck and other tool reports

For Mac:

• Cppcheck
• Built-in leaks tool

For Windows:

• Cppcheck
• Visual Leak Detector