amerand/pmoired

Display and fit Optical (spectro-)Interferometric OIFITS data

I am an 🔭astronomer🔭 keen on sharing my experience and expertise via my codes! I thouroughly check my implementations for accuracy, but these are still research codes, and they may contain bugs: If you use my codes, please give me feedback (report issues, request features, etc). The codes below have reference publications, and have been used in more than 80 refereed publications as of mid-2023.

• SPIPS models spectroscopic, photometric and interferometric time series observations of Cepheids pulsating stars. It is used to derive fundamental parameters, and interpolated light curves. It is described in Mérand et al. A&A 581-80 (2015). ✨Highlight✨ It has been used to create a PCA templates of light curve to re-analise independetly some of the SH0ES data in Javanmardi, Mérand et al. ApJ 911-12 (2021) to measure the Hubble constant
• CANDID aims at detecting faint companions around stars in interferometric data, co-developped with Alexandre Gallenne (who hosts a version with a GUI). It gives you an upper limt for non-detection. The algorithms are described in Gallenne, Mérand et al. A&A 579-68 (2015). ✨Highlight✨ CANDID has been used in 60 refereed publications in less than 8 years!
• PMOIRED is an advanced tool to model interferometric data and help astrophyscal interpretation. The algorithms are described in Mérand, SPIE Volume 12183, id. 121831N (2022) ✨Highlight✨ It was used to disprove the presence of a black hole in the HR6819 system, as published in Frost et al. A&A 659-L3 (2022)

pmoired's Issues

Arbitrary profiles don't seem to work

Trying to run the example for arbitrary radial profiles causes an error.
Am I doing something wrong?

param = {'diam':1.0, 'profile':'$MU**$alpha', '$alpha':0.1}

data.doFit(param)

[dpfit] 2 FITTED parameters: ['$alpha', 'diam']
[dpfit] using scipy.optimize.leastsq
Traceback (most recent call last):

File "/usr/lib/python3/dist-packages/IPython/core/interactiveshell.py", line 3331, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)

File "", line 8, in
data.doFit(param)

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/init.py", line 191, in doFit
self.bestfit = oimodels.fitOI(self._merged, model, fitOnly=fitOnly,

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/oimodels.py", line 1795, in fitOI
fit = dpfit.leastsqFit(residualsOI, tmp, firstGuess, z, verbose=verbose,

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/dpfit.py", line 361, in leastsqFit
scipy.optimize.leastsq(_fitFunc, pfit,

File "/usr/lib/python3/dist-packages/scipy/optimize/minpack.py", line 383, in leastsq
shape, dtype = _check_func('leastsq', 'func', func, x0, args, n)

File "/usr/lib/python3/dist-packages/scipy/optimize/minpack.py", line 26, in _check_func
res = atleast_1d(thefunc(*((x0[:numinputs],) + args)))

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/dpfit.py", line 673, in _fitFunc
model = func(x, params)

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/oimodels.py", line 1615, in residualsOI
res = np.append(res, residualsOI(o, param, timeit=timeit))

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/oimodels.py", line 1646, in residualsOI
m = VmodelOI(oi, param, timeit=timeit)

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/oimodels.py", line 884, in VmodelOI
return VsingleOI(oi, param, imFov=imFov, imPix=imPix, imX=imX, imY=imY,

File "/home/pboley/.local/lib/python3.8/site-packages/pmoired-0.1.dev0-py3.8.egg/pmoired/oimodels.py", line 423, in VsingleOI
Ir = eval(tmp)

File "", line 1
_mu**$alpha
^
SyntaxError: invalid syntax

Wrong results starting from a specific position

Hello,
I discovered, trying to loop over a bunch of files extracted from OiDB for a technical comparison that starting from "bad" values often converge to wrong results.

This seems the case starting to fit a disk from diameter=0. It probably exists a way to avoid such cases and this may point to other related numerical issues ? I know that other tools sometimes add the smallest values just to avoid an exact 0, but this is all I can say ;)

I may have skipped some of your documentation...

Thank you for your tool!

Guillaume

_

oifake.py fails to import because of missing file newVltiHzn_obsDoors.txt

The title says it all. newVltiHzn_obsDoors.txt is not present in the repository...