amfoss/templeapp

Android App which handles the information about temple. People can register and keep a track of all poojas, donations made to the temple.

templeapp's Issues

Use Proper Annotations and Comments

Describe the chore
In some places comments are given without proper annotations
eg:
TempleApp/src/main/java/example/TempleApp/Activities/MainActivity.java

The comment given is:

/**
 * Created by Chromicle.
 */

Where it should be

/**
 * @author Chromicle
 */

Would you like to work on the issue? (Yes/No)
No

Replace User Id with Employee Id

Describe the chore
The User Id in Add Pooja/Donation should and Edit pooja/Donation should be replaced with Employee Id
Would you like to work on the issue? (Yes/No)
No

Rename the app package.

Describe the feature you'd like
Currently, the app package is com.example.TempleApp. Rename it to org.amfoss.TempleApp and made any other changes required for this.

Would you like to work on the issue? (Yes/No)
No.

Add scroll bars to "delete" and "read" layouts as when user changes the orientation,user is unabale to see the "find" button

Describe the bug
A clear and concise description of what the bug is.
When user changes the orientation, "find" button is unavailable as there is no scroll view to "update" and "delete" layouts. So it will be better to add scroll bars to "delete" and "update" layout.
Screenshots
If applicable, add screenshots to help explain your problem.


Would you like to work on the issue?

• Yes
• No

Improvements in the UI of MainActivity

The UI of MainActivity can be improved.

As there are many buttons, we can have a grid view with relevant pictures for each feature.

I have attached an example below.

Section for amount paid for pooja.

Describe the feature you'd like
When a user registers for new pooja and clicks paid, another entry should be made for the amount paid.

Would you like to work on the issue?

• Yes
• No

Scroll function is not available on screen rotation

Describe the bug
On screen rotation, the scroll option is not available on the home screen and the screen is just set to some limited options.

To Reproduce
On home screen switch to landscape mode.

Screenshots

Typos in the strings used in the app.

Describe the bug
There are a few typos in the strings used in the app.

Expected behavior
These typos should be removed.

Would you like to work on the issue?

• Yes
• No

Change Issue Template of the Repository.

Describe the chore
The "Yes"/"No" is recognized as a checklist by Github. So, selecting one will show in the issues as "1 of 2 completed", which is not something that was meant.

Scrolling is unavailable for "read_all" layout

Describe the bug
When the user changes the orientation, "ReadAll" button is unavailable as there is no scroll view to "read_all" layouts. So it will be better to add scroll bar to the layout.

Would you like to work on the issue? (Yes/No)
Yes

Toast messages are displayed for a very long time

Describe the bug
The toast messages under all section are displayed for a very long time.

To Reproduce
Select any section from the home screen and observe that the toast message appears at the bottom of the screen for a very long time.

Expected behaviour
The toast message should be displayed for a shorter duration.

Update screenshots in readme.

Describe the chore
UI has been changed a lot. Please update screenshots in readme.

Would you like to work on the issue? (Yes/No)
NO.

Refactor the app code.

Describe the chore
The language/grammar being used in the app needs to be refactored. Almost all sentences currently end with "only". This is one of the issues that need fixing. Refactor any other grammatically wrong strings in the app too.

Would you like to work on the issue? (Yes/No)
No

Integrate Travis CI

Describe the chore
Integrate Travis CI

https://docs.travis-ci.com/user/languages/android/
https://medium.com/@harmittaa/travis-ci-android-example-357f6e632fc4

Would you like to work on the issue?

• Yes
• No

change and indentation for spotless to 4

Describe the chore
indentation for spotless to 2 spaces. To change and apply spotless with indentation 4 spaces.

Would you like to work on the issue?
Yes

Add screenshots of the app to README.md

Describe the chore
Screenshots of the current UI of the app should be added to the README. They can continuously be updated when the UI is updated.

Would you like to work on the issue?

• Yes
• No

Allow user to fetch multiple details in read all

Describe the feature you'd like
Currently, the user can fetch only any one of the details in read_all so allow user to fetch multiple details
ex: both paid and not paid
Only paid
Only not paid

Additional context
Do not allow user to fetch donations and registrations at a time
You can do that by making checkbox instead of radio buttons

Add release-drafter for maintaining a changelog during releases.

Describe the chore
Add release-drafter for maintaining a changelog during releases.

Would you like to work on the issue? (Yes/No)
YES.

It will be better to restrict user to add either "user ID" or "name", without leaving both details empty

Describe the bug
At present, user is allowed to submit details without filling both user Id and name.It will be better to restrict user to add either "user ID" or "name", without leaving both empty.

Screenshots

Would you like to work on the issue?

• Yes
• No

Remove Hardcoded Strings and Texts

Describe the chore
There are about 84 Hard coded Strings and 30 Hard coded text in the whole project it would be really nice if these resources are extracted.

Would you like to work on the issue? (Yes/No)
No

Screenshots

Add auto-label bot.

Describe the chore
Add auto-label bot for automatically labeling prs.

Would you like to work on the issue? (Yes/No)
YES.

Use dimensions from dimen resources.

Describe the chore
Currently, the xml files are using hardcoded dimensions. Store those dimensions in the dimens resource files and use them from there.

Would you like to work on the issue? (Yes/No)
NO.

change alert dialogue messages

Describe the chore
The alert dialogue currently shows messages like "Hey please wait" and "I am fetching your Json" replace this with proper messages.
Would you like to work on the issue? (Yes/No)
No

Replace App icon

Describe the feature you'd like
Currently, the icon we are using is a google search result image, hence might have copyright issues.

Additional context
If anyone is willing to make a new icon, upload the image here in the comments sections for everyone to review and provide opinions.

Update README file

Describe the chore
Replace the old screenshots with new UI, the workflow and license badge

Would you like to work on the issue?
No

Create layouts for Add Pooja and confirm details

Describe the chore

create the layouts for Add Pooja and Confirm details please fallow the mockups while creating any view

Additional
I would recommend to use this Material Text feild for editTexts

Would you like to work on the issue? (Yes/No)
No

Improve mainactivity UI

Describe the chore
The Main Activity UI can be made more user friendly, follow the screenshots that are attached for the implementation.

Would you like to work on the issue? (Yes/No)
No

Remove personal branding from source files

Describe the chore
Remove <!-- Created By Chromicle --> branding on app source files

Would you like to work on the issue? (Yes)

Rearrangement in Add Pooja/Donation

Describe the chore
In the add Pooja/Donation the field for Name should come after User Id
Would you like to work on the issue? (Yes/No)
No

Select pooja type appears on donate money to temple

Describe the bug

Select pooja type text is appearing on clicking Donate money to temple.

To Reproduce
Steps to reproduce the behavior:

• Click on Add pooja/donation
• Click on Donate Money to Temple

Expected behavior
Select pooja type text should not be there

Screenshots

Smartphone

• Device: OnePlus6t Mclaren
• OS: Android 9 Pie

Would you like to work on the issue? (Yes/No)
No

fix: Update URL to fix issue with fetching google sheet api

Describe the bug
No data is being logged with the google sheet API
Would you like to work on the issue? (Yes/No)
No

Add spotlessCheck.

Describe the chore
Add spotless check for proper code formatting.

Would you like to work on the issue? (Yes/No)
YES.

Displaying non-functioning editTexts

Describe the bug
Currently, when we inserting donations, there are 2 non-functioning edit texts with hints as customPooja and amount. Hide them when we insert a new donation.

To Reproduce
Steps to reproduce the behavior:

1. Go to InsertActivty
2. Select Donations
3. Scroll down'
4. 2 non-functioning editTexts can be seen.

Expected behavior
editTexts should be hidden when we are inserting donations.

Screenshots

Smartphone (please complete the following information):

• Device: Samsung J8
• OS: 9 Pie

Would you like to work on the issue? (Yes/No)
No

Edit textbox dimension

Describe the bug
The size of the text box under Search ID and Delete Pooja/Donation should be changed for the watermark to appear.

Update README to include retrofit

Describe the chore
As now it uses Retrofit the dependencies README can be updated
and the workflow can also be updated

Would you like to work on the issue?
No

The UI is not proper while viewing all donations/pooja

Describe the bug
At the side in the view of all donations/pooja the UI is no proper

To Reproduce
Steps to reproduce the behavior:

1. Click View All Pooja/Donation
2. Check Registered Poojas
3. The UI is not proper

Expected behavior
The UI should be clear

Screenshots

Smartphone (please complete the following information):

• Device: Vivo V5s
• OS: Android 7

Would you like to work on the issue?
No

Inserting wrong ID

Describe the bug
When we insert values once again instead of coming back to the main activity then the username is not inserted in the correct way.

ex:

First time: hello
Second time: hellohello
Third time: hellohellohello

To Reproduce
Steps to reproduce the behavior:

1. Go to insert_activity
2. Insert any values
3. Instead of coming back to main activity insert once again
4. See the database
5. Observe the error

Expected behavior
Inserting new values should happen properly.

Smartphone (please complete the following information):

• Device: Samsung J8
• OS: Android 9 Pie

Would you like to work on the issue? (Yes/No)
No

Apply spotless check and add it to travis.

Describe the chore
Apply spotless check to refactor files according to java code style and add a spotless check to travis.

Would you like to work on the issue? (Yes/No)
YES.

Add an apk branch

Describe the chore
Add an apk branch so that anyone can download the apk and test the app without building it using the Android Studio.

Would you like to work on the issue? (Yes/No)
YES.

Crash: App is crashing when we select donations in readAll Activity

Describe the bug
App is crashing when we click on readAll after selecting donations to see all list of donations

To Reproduce
Steps to reproduce the behavior:

1. Go to readAll Activity
2. Select Donations and click readAll
3. See error

Logs

beginning of crash
2019-07-08 18:14:09.047 3902-3902/org.amfoss.templeapp E/AndroidRuntime: FATAL EXCEPTION: main
Process: org.amfoss.templeapp, PID: 3902
java.lang.ArrayIndexOutOfBoundsException: length=3; index=3
at org.amfoss.templeapp.adapter.MyArrayAdapter.getView(MyArrayAdapter.java:50)

Smartphone (please complete the following information):

• Device: Samsung J8
• OS: Android 9 Pie

Would you like to work on the issue? (Yes/No)
No

Add a section for custom poojas and amout paid for a pooja.

Describe the feature you'd like
Add a section for custom pooja and predefined pooja type.
If the user selects custom pooja, allow the user to name the pooja and enter the tentative amount to be paid.
If predefined pooja type is selected, then show the spinner that is displayed currently and automatically fill the money to be paid.

EX:
Type1 - ₹100
Type2 - ₹250
Type3 - ₹150
Type4 - ₹500

Would you like to work on the issue?

• Yes
• No

Directory names should be starting with small letters

Describe the chore
Directory names should start with small letters but here they are starting with capital letters. It has to be changed.

Would you like to work on the issue?
No

App bar label is minimized on orientation change

Describe the bug
When the user switches to landscape mode, the app label is minimized.

Steps to reproduce

• Run the application.
• Enable the orientation to landscape.

The label text size should remain the same.

Edit toast messages in Search section

Describe the bug
When user clicks on "people who registered "in search section, wrong toast is appearing as"Selected to register pooja". It is repeating with "People who Donated money".

Expected behavior
A clear toast message.

Screenshots

Would you like to work on the issue? (Yes/No)
No.

Edit text for Amount disappearing

Describe the bug
After clicking on Donate Money to Temple if we return click on Register for New pooja the edit text field for Amount disappears

To Reproduce
Click on Add Pooja/Donation
Click on Radio button to add new Pooja
Click on Radio button to Donate Money to Temple
Again Click on Radio button to add new Pooja
Expected behavior
The amout text field should remain but it disappearing.

Smartphone (please complete the following information):

• Device: OnePlus 6t Maclaren
• OS: Android 9 Pie

Would you like to work on the issue? (Yes/No)
No

Make mockup for Improvising UI

Describe the chore
Currently the UI is not much user friendly so It has to be made made in such a way that the targeted audience can use them without any learning curve, to achieve this we need a proper mockup.
Would you like to work on the issue? (Yes/No)
No

Data Binding

Describe the chore
Currently the app is using the normal findViewById for linking the UI with the methods this will sometimes result in crashes and poor performing apps. It would be really nice if Butter Knife Library by Jake Wharton is used for View Binding

Would you like to work on the issue? (Yes/No)
No

Title mismatches at readAll activity

Describe the bug
In ReadAll activity, while fetching data if we want to fetch both paid and not paid so while showing list view heading does not match

To Reproduce
Steps to reproduce the behavior:

1. Go to ReadAll activity
2. Click on both paid and not paid and readAll
3. observe at the top
4. See error

Smartphone (please complete the following information):

• Device: Samsung j8
• OS: Android 9 Pie

Would you like to work on the issue? (Yes/No)
No

Use retrofit in the app.

Describe the feature you'd like
Use retrofit in the app.

Would you like to work on the issue?

• Yes
• No

Restrict editTexts to take numbers only as input for Amount

Describe the bug
Currently, edit texts for amount of money donated is accepting all type of texts restrict them to take input only numbers

Expected behavior
EditTexts should take only numbers as inputs

Smartphone (please complete the following information):

• Device: Samsung j8
• OS: Android 9 pie

Additional context
Please update in all activities
Make editTexts view with keyboard number only

Would you like to work on the issue? (Yes/No)
No