amhk/attic-lokatt

Wrapper for 'adb logcat'

attic-lokatt's Issues

Manual markers in log

Adding this here as a reminder for the future
Add the possibility to manually inject markers in the log to keep track of an event flow.

gui: log filtering

Filter the log based on the different log message attributes

Needed-by: #20

Improve performance of lookup_process_name

lookup_process_name will create a new "adb shell" connection for each call, which is a performance bottleneck. Create a persistent "adb shell" connection on which all shell commands can execute.

adb.c: use kernel driver style 'op struct'

Make adb agnostic to how commands are implemented. Instead, defer actual command execution to functions specified in an operations struct (think kernel modules). Add different backends for talking with adb (preferably via the adb protocol, see #18) and for reading from a file.

scripts: pre-commit-hook: incorrect line numbers

It seems the pre-commit-hook gets the line numbers wrong. Investigate and fix.

common/python: use filters

Use the filter functionality introduced in #16 from the common python lib.

Depends-on: #16
Needed-by: #17

gui: predefined output formats on par with adb logcat

Adb logcat support the following formats
"adb logcat -v brief" - Display priority/tag and the PID of process issuing the message (the default format).
"adb logcat -v process" - Display PID only.
"adb logcat -v tag" - Display the priority/tag only.
"adb logcat -v raw" - Display the raw log message, with no other metadata fields.
"adb logcat -v time" - Display the date, invocation time, priority/tag, and PID of the process issuing the message.
"adb logcat -v thread" - Display the priority, tag, and the PID and TID of the thread issuing the message.
"adb logcat -v threadtime" - Display the date, invocation time, priority, tag, and the PID and TID of the thread issuing the message.
"adb logcat -v long" - Display all metadata fields and separate messages with a blank lines.

lokatt should support the same -v params mapping to predefined filters matching the format from adb logcat

add test cases for bridge.c

add test-bridge.c and implement relevant test cases

liblokatt: convert adb backend to talk with the adb server directly instead of fork + exec adb

Replace today's solution where adb.c forks and execs the standalone adb binary with an implementation that talks directly with the adb server using the adb protocol (just like DDMS does it).

pre-commit-hook: exactly 80 chars is considered too long

The "line too long" check should check for ".{81}", not ".{80}" as is done today.

Automatic add2line translation of native crashes

Given paths to symbols and cross-compiled addr2line and similar tools, automatically translate native crashes to source code file + line.

add test cases for demux.c

add test-demux.c and implement relevant test cases

liblokatt: filter: better error messages

Have create_filter accept an optional out-paramter (of type struct strbuf *). If there is an error while creating the filter, the strbuf should contain a message intended to be shown to the end user.

The lexer already contains logic to pinpoint what character in the input caused problems. The parser needs to be refined -- perhaps add more logic to tokens about where in the input they came from?

Hide struct adb_stream

Rather than returning a struct adb_stream from create_adb_stream and related functions, a void * handle should be returned.

The same should be done for lokatt_session and lokatt_channel in lokatt.h.

liblokatt: save adb stream to file

It should be possible to log the binary output from adb to file.
It should be possible to start a lokatt_session with a logfile as input.

This should probably be implemented in the layers below demux.c with the needed paramaters (i.e file path) passed on from create_lokatt_session in demux.c