Slow

[DrXenos]

Slow

[amichaeltm]

Actually it's faster than the Java version in every test run I've ever done and that was with next to zero optimization effort.

Also, no it's not passing containers and strings that are being copied when passed via value. I don't think you actually understand how Qt containers and QString even works. QString is CoW and is only copied if edited. Same with the containers like QVector.

https://doc.qt.io/archives/qt-4.8/implicit-sharing.html

Many C++ classes in Qt use implicit data sharing to maximize resource usage and minimize copying. Implicitly shared classes are both safe and efficient when passed as arguments, because only a pointer to the data is passed around, and the data is copied only if and when a function writes to it, i.e., copy-on-write.

And if you read the list of classes that use implicit sharing, you'll see that all of the ones used in this code base are on that list. Maybe you should have done more than a quick look since your hot take is based in complete ignorance?

If you think you can do better, please feel free to submit a pull request along with actual benchmarking to show your version makes things any faster.