amichaelt/bdsup2subplusplus

Port of the original BDSup2Sub to C++ and Qt.

bdsup2subplusplus's Issues

Integrate transparency fix for SUB/IDX

Integrate the transparency fix from mjuhasz's WDTV live branch.

Add support to split subtitle files

Add support to merge SUB/IDX streams

Add support so that multiple SUB/IDX streams can be merged into one and exported. Depends on fixing the output to support multiple languages.

Fix palette color matching when converting from BD SUP to Vobsub

When converting from BD SUP to Vobsub the colors in the palette are not always chosen correctly.

Enhance XML/PNG parsing and decoding to support multi-graphic XML

Need to support reading BDN+XML with subtitles that have two graphics.

Qt6 compatibility,...

would be nice if BDSup2SubPlusPlus could be adjusted to support Qt6

Add support for DVB subtitles.

Add support for bitmap DVB subtitles.

Crash when navigating to multi-region subtitle.

I found a problem when loading the file below into 102b_20131303_Win32. Whenever I go to the multi-region subs it throws an exception.

http://www.sendspace.com/file/5cunw7

CLI v1.0.2a Crashes on Empty (?) .sup Files

Some source materials contains .sup files that are very small (~ 1 kByte). I assume that these are empty, pro-forma subtitles. Loading one of these in GUI mode results in the following log:

Loading foobar.sup

> 1 (00:00:01.001)

PCS ofs:0x00000000, START, size:0x000b, comp#: 0, forced: false
PTS start: 00:00:01.001, screen size: 1920_1080
WDS ofs:0x00000018, size:0x000a, dim: 10_10
PDS ofs:0x0000002f, size:0x0007, ID: 0, update: 0, 1 entries
END ofs: 0x00000043
PCS ofs:0x00000050, NORM, size: 0x000b, comp#: 0, forced: false, pal update: false
PTS: 00:00:01.043
WDS ofs:0x00000068, size:0x000a, dim: 10*10
END ofs: 0x0000007f
WARNING: missing PDS/ODS: last epoch is discarded

Detected 0 forced captions.

That is fine, but when loading the same .sup on the command line:

bdsup2sub++ --output "foobar.idx" "foobar.sup"

results in a crash. That may not seem like a big issue, but it is somewhat of a pain when scripts automatically invoking bdsup2sub++ hang at this point. It seems the proper behavior would be to output an empty result, rather than crashing.

.sup are losing their transparency after being processed by bdsup2sub++

tried on the latest version - still no luck..
http://gyazo.com/40d2762416ee84c2d0709258d65d1936
here how it looks after processing with this program
and here's a sample before processing
https://dl.dropboxusercontent.com/u/372935/test.sup

Support for Qt5

Hi (and Happy new year)

Any plans for add suport for build with Qt5 Toolkit?

greetings

Slow

This code is embarrassingly slow compared to the Java version. Perusing the code, it's easy to see why. You're sending containers and strings to functions as value parameters, which means they will be copied every time function is called. There are probably lots of other stuff, but I just took a quick look.

Add proper support for fade and palette/alpha update effects.

bdsup2sub does not properly support fade effects, palette animations and palette/alpha updates.

Enhance XML/PNG output to support multiregions

Need to enhance the XML/PNG output to properly support multiregions for importing into programs such as Scenarist.

Allow selecting language and palette from IFO

When loading an IFO/SUP pair, allow the user to select the language and palette in case there are multiple.

1.0.2b Crashes on Exporting Many .sup to .sub

This issue is unrelated to my previous issue with 1.0.2a, except that it occurs on a set of .sub files which previously exported fine using 1.0.2a but now cause crashes on 1.0.2b (which did fix the previous issue).

A large number of .sub files which I had previously (apparently) correctly converted using 1.0.2a now cause crashes when exporting to .sub in 1.0.2b. One example file is available at this link: http://www.mediafire.com/file/xhix4okogg3osy6/barbaz.sup

To reproduce the error on the CLI use:
bdsup2sub++ --output barbaz.sub barbaz.sup

When invoking bdsup2sub++ from the GUI, the .sup file appears to load without error but when displaying frame 11 (or attempting to export), the program crashes.

Unknown header errors from BDSup2Sub generated idx/subs

I'm in the process of building a tool to automatically mux external subtitles into MKV files with the video and audio streams, and I am periodically running into idx/sub files that generate an Unknown header error. I've linked to a sample of these problem files in my repo.

https://github.com/jerblack/server_tools/blob/master/mux/problem/movie.idx
https://github.com/jerblack/server_tools/blob/master/mux/problem/movie.sub

The reason I'm bugging you about it is that the second line of the idx/sub files I am seeing these problems with says "# Created by BDSup2Sub 5.1.2".

Here's an example of what I see when I attempt to remux those subtitles into an mkv with mkvmerge. The resulting file plays, but with no subtitles displayed.

$> mkvmerge -o out.mkv movie.mkv movie.idx
mkvmerge v31.0.0 ('Dolores In A Shoestand') 64-bit
'movie.mkv': Using the demultiplexer for the format 'Matroska'.
'movie.idx': Using the demultiplexer for the format 'VobSub'.
'movie.mkv' track 0: Using the output module for the format 'AVC/h.264'.
'movie.mkv' track 1: Using the output module for the format 'DTS'.
'movie.idx' track 0: Using the output module for the format 'VobSub'.
The file 'out.mkv' has been opened for writing.
Warning: 'movie.idx': Unknown header 0x00000164
Warning: 'movie.idx': Unknown header 0x00000160
Warning: 'movie.idx': Unknown header 0x00000160
Warning: 'movie.idx': Unknown header 0x00000104
Warning: 'movie.idx': Unknown header 0x00000104
Warning: 'movie.idx': Unknown header 0x00000104
Warning: 'movie.idx': Unknown header 0x00000178
Warning: 'movie.idx': Unknown header 0x0000013c
Warning: 'movie.idx': Unknown header 0x0000013c
Warning: 'movie.idx': Unknown header 0x0000013c
Warning: 'movie.idx': Unknown header 0x00000164
Warning: 'movie.idx': Unknown header 0x00000160
...
Warning: 'movie.idx': Unknown header 0x00000148
Warning: 'movie.idx': Unknown header 0x00000104
Progress: 100%
The cue entries (the index) are being written...
Multiplexing took 13 seconds.

If I attempt to run the file through vobsub2srt, I get a similar error and a zero-byte srt.

$> vobsub2srt movie
unknown header 0x00000164
VobSub: mpeg_run error
Wrote Subtitles to 'movie.srt'

Do you know of anything I can do to recover these files or make them usable again? Thanks.

Add conversion to 960x720

Could you please make it possible to convert the resolution to 960x720?

Optimize BD SUP output

Scaling and moving doesn't work correctly with multi-region/graphic subs.

Add conversion to 768x576

Could you please make it possible to convert the resolution to 768x576?

If invalid palette INI file is loaded it will cause all colors to be set to black

If the palette file is specified to be loaded is not a valid PGCEdit Palette file all colors will be set to black.

Fix move from original y position functionality

The "move from original y position" functionality in the GUI does not currently work correctly by not allowing positive values.

Add support for 3d SUB/IDX

https://forum.doom9.org/showpost.php?p=1581216&postcount=1115

Improve parsing of BDSUP files using multi-regions

Need to enhance BDSup2Sub's SUP parsing code to handle multiregions.

Infinite loop in SubPictureBD::isForced and setForced

When editing a particular subtitle (which is attached) when opening the "edit frame" window for the last frame the application hangs.
The issue appears to be in SubPictureBD::isForced and setForced, the for loops forever. I've done some tests and it seems that the issue occurs when the list size is 2.
I managed to solve the issue by making a copy of imageObjectList size and using the copy in the for condition. I have no idea if there is a side effect to this patch.

Subtitle.sup.zip

Be able to load DVD directly to output subtitles

Add functionality to be able to open DVDs directly in order to save out the subtitle files rather than having to extract beforehand.

Write settings to proper data directory

Instead of writing the INI settings to the installed directory change the behavior so it is written out to %APPDATA% on Windows and $HOME/.config on *nix platforms.

Add support for exporting multi-language SUB/IDX

Need to fix the output code so that all languages are exported out and just the langidx is set to the default language.

Fix subtitles having black box around them

VobSub output occasionally has subtitles with black backgrounds. Need to fix.

Problem files:
http://www.mediafire.com/?ca3xegs8uxtxx1w
http://www.mediafire.com/?4r3a3j6zn356j01

File from AVIAddXSub without issue:
http://www.mediafire.com/?f5h6w747xl10fct

Add possibility to shift the subpics in X or Y direction by N pixels

See original request here: http://forum.doom9.org/showthread.php?p=1574490#post1574490

Detection of filters when called via CLI is broken.

When specifying a filter via CLI the code to detect whether it exists in the list of scaling filter is broken.

Multilanguage idx/sub to multiple xml/png outputs in CLI

Hello,

I'm trying to convert an idx/sub containing several languages, into XML/PNG format, using the command line:

bdsup2sub -o output.xml input.idx

But, the output is only the first language, in the format output.xml and output_0001_0.png

So, is it possible to output all at once, or to specify the index of the language from the command line?

CRASH loading English SUP file from Avatar BD

SUP file from Avatar BD crashes program.

Link to file here: https://www.dropbox.com/s/ma8ani658l8vsg3/sub3.sup

Automate BDSup2Sub++

I have hundreds of subtitles to process. I want to write a script to automate this. For each subtitle, I want to Scale 50% and move all captions outside Y-bounds. I am looking for a solution where I can launch BDSup2Sub processes without launching the UI. Is this possible?

Skip frame buttons not implemented in edit frame dialog

Need to implement the 4 skip frame buttons in the edit frame dialog.

Enhance BDSUP output to keep multi-region subpictures

Need to fix BDSUP output so that multi-region subpics are output with both regions instead of being merged as one.

Another .sup File That Crashes bdsup2sub++ 1.02b

Thanks to your help with previous sup files, I have not had a problem with converting my blurays lately, but now I've run across another .sup file that crashes bdsup2sub++ in a reproduceable manner either from the GUI (when saving to idx/sub) or when invoked from the command line as follows:

bdsup2sub++ --resolution keep --output "qunc.idx" "qunc.sup"

I've uploaded the failing qunc.sup file at http://www.mediafire.com/download/p4p8c35rsca5l3q/qunc.sup

Can you have a look at this please? Thanks!

Not getting bit exact output between CLI and GUI.

When exporting the same file as the same format, the output is not bit-exact.