Allow longer database names

[amp-cli]

Allow longer database names

[totten]

Agree that would be good.

IIRC, the constraint originated because the DB name matched the DB username, and the DB username (up until 5.7.8) was limited to 16 char. But really it's OK for the DB and user to be a little different.

[totten]

@michaelmcandrew This should be improved by #54 (amp v0.5.0).

[totten]

Re-reading, do you think it's worth reopening to (a) go all the way to 64 chars and (b) put a delimiter between the build and DB names (i.e. dmastercivi_12345 => dmaster_civi_12345)?

Adding the extra delimiter would reduce the legibility of usernames (which are only 16 char) but should improve it in the DB names (which are longer - and which we actually reference more often).

[michaelmcandrew]

Hey there,

The background for me was that reasonably short (using my definitition of reasonably short) prefixes were getting truncated and that was a bit frustrating.

I suspect that the extra 16 characters is going to be more than enough in this case.

Most likely out of scope of this ticket / just thinking aloud, there is the whole other question of whether you actually need to add randomness onto the end of the DB names.

[michaelmcandrew]

But to answer your specific points:

(a) go all the way to 64 chars

Yeah, why not? My understanding of createHintedRandom is that it only adds 5 characters of random so it will only generate a 64 character db name if $hint is very long.

(b) put a delimiter between the build and DB names (i.e. dmastercivi_12345 => dmaster_civi_12345)?

Also yes, that would be a great usability improvement.