Setting custom timeout doesn't seem to do anything

[twinge]

Setting custom timeout doesn't seem to do anything

[amro]

Hi Josh,

Are you using 0.3.5? What version of Ruby are you using? I'm not seeing this behavior w/ 1.9.3 and Gibbon 0.3.5. In irb, I can set and retrieve the timeout value without issue.

1.9.3p194 :024 >   g = Gibbon.new('...')
 => #<Gibbon:0x007fba9e89fbd8 @api_key="....", @default_params={:apikey=>"..."}, @throws_exceptions=false> 
1.9.3p194 :025 > g.timeout = 1000
 => 1000 
1.9.3p194 :026 > g.timeout
 => 1000 

Happy to fix the problem if you can help me reproduce it. I'm not sure it's worth targeting Ruby <1.9 but if it's an easy fix, I don't mind.

[twinge]

I found my mistake. I had wrapped the Gibbon.new call in a method, and was calling the method each time. So timeout was getting set on the return from the method, but a new Gibbon object was being created on each invocation of the wrapper method. Subtle mistake. Sorry for bothering you. You might want to delete this issue since it shows your api key :)

[amro]

Glad you found the problem and it's working for you.

Bah, thanks. I missed the second occurrence of it. It's disabled now -- no biggie.

[awaage]

I noticed that setting timeout in the options_hash (like the example) does not work:
@client = Gibbon.new(api_key, {:timeout => TIMEOUT})

However, setting the timeout like this works:
@client = Gibbon.new(api_key)
@client.timeout = TIMEOUT

Took a quick look through the code, and I don't see where the timeout is set from options.

[amro]

Hi Andrew,

The doc is currently for version 0.4.0, which has not yet been released (because I've yet to fully test it). Version 0.3.5 requires that one set the timeout after initialization, as you've found. I've not yet tested setting the timeout in the options with the latest code.

I hope to release 0.4.0 really soon.

[awaage]

Thanks for the clarification.