Handle non-JSON response from Mailchimp

[dmitryn]

Handle non-JSON response from Mailchimp

[amro]

I think MailChimp was DDOS'd yesterday. That may have caused this.

What's your proposed solution? Rescue and reraise as a Gibbon typed exception?

[dmitryn]

@amro right. I think raising MailChimpError will work here. Not sure what the error message and code should be though.

[amro]

Sorry for the delay. I agree. I'll do this as time permits but give me a few days, please.

[dmitryn]

@amro sure. It's not urgent. Thanks.

[amro]

Gibbon users can opt to do their own error checking so what I've done is rescue MultiJson::ParserError and return an error hash similar to what MailChimp does.

If the user has opted to check for errors manually, their code will now work instead of blow up.

If they've opted to let Gibbon raise errors, their rescue block will catch Gibbon::MailChimpError and their code will also work instead of blowing up.

What do you think of this solution?

[dmitryn]

@amro i think it's a good solution.

[amro]

Cool. I'll release this a contribution from someone else now.