anandts88/ember-validator

Perform Ember Object Validation

ember-validator's Issues

Allow validateMap model param to be plain object

It would be helpful if the object being validated was not restricted to an Ember Object

this.validateMap({ model: myPOJO, validations })

`this.container` deprecation

If a consuming application using this addon updates to Ember >=2.3.0, deprecation messages will be triggered when the following line is hit. https://github.com/anandts88/ember-validator/blob/master/addon/mixin.js#L217

See new getOwner(this) API for this specific case http://emberjs.com/deprecations/v2.x/#toc_deprecations-added-in-2-3

Specifically the https://github.com/rwjblue/ember-getowner-polyfill to support a wide array of Ember versions.

Issue with hasSpecial pattern validator

I'm trying to use the pattern validator to validate a password. My code looks like this:

  pattern: {
    hasNumber: true,
    hasSpecial: '!@#$&*',
    messages: {
      hasNumber: 'Password should contain at least one number',
      hasSpecial: 'Password should have at least special'
    }
  },

But somehow the it was not working. So went debugging in your add-on's code, and found an issue.

I'm using version 1.2.7, and the issue was on the file ember-validator/addon/mixins/pattern.js.

In this part of the code, at the end of every regex you are doing the test with .test(value).

if (this.options.hasSpecial) {
  if (typeof(this.options.hasSpecial) === 'string') {
    specialTest = new RegExp('(?=.*[' + this.options.hasSpecial + '])').test(value);
  } else if (this.options.hasSpecial.constructor !== RegExp) {
    specialTest = this.options.hasSpecial.test(value);
  } else {
    specialTest = new RegExp('(?=.*[!@$%^&*()-+_=~`{}:;"\'<>,.|?])').test(value);
  }
}

So this is making the variable specialTest a boolean, right ? Because of .test(value) result.

But later on in the code, you are doing this test:

} else if (this.options.hasSpecial && !specialTest.test(value)) {
    this.pushResult(this.options.messages.hasSpecial);
}

And that's causing an error, because !specialTest.test(value) is trying to call the method test in a boolean variable, and not in a regex.

I think the best solution would be to remove the .test(value) from where you define specialTest.

I hope it helps! :)

Numeric validator is not working for zero value.

Numeric validator - "notEqualTo" is not validating if 0 is passed.

Add Tests

Placeholder issue here. Currently this addon is untested, Adding tests will allow a safer upgrade path.

Unique property value.

Hi! I've tried to make a custom validation that verifies if the property value is unique in all records on ember-data.
The problem is that the validators don't wait the findAll promises be resolved to validate de object. Any ideas on how can I make this?

Allow multiple custom on-the-fly inline validators per validation object

The following restricts each validation object to allowing a maximum of one custom property. We should expand this restriction to allow the ability to add multiple custom on-the-fly validators per validation object.

ember-validator/addon/mixin.js

Line 412 in f8e806b

if (validatorName === 'custom' ) { // If the validator is custom then create custom validator.

Remove dependency on bower

This can easily be done by installing moment.js through npm and changing the path to the moment dist in the index.js file.

`moment.js` date construction using a non-iso string is deprecated

moment.js deprecation warnings may be triggered during date validation. Issues may occur here https://github.com/anandts88/ember-validator/blob/master/addon/mixins/date.js#L49 and here https://github.com/anandts88/ember-validator/blob/master/ember-validator-non-cli.js#L241.

construction using a non-iso string is deprecated (see moment/moment#1407). One possible fix is to just always provide the native new Date(...) constructor as the argument to moment(...).

moment(new Date("2016/01/01"));