anchor/docker-build

A basis for docker builds

docker-build's Issues

Bail out when errors occur?

The main script base has set +e. I would prefer if we could have the script fail when an error occurs, rather than continue on blithely.

In cases where an operation may fail, and we're OK with it, we can always add || true to it.

What do others think?

Use $GIT_BRANCH as content of created docker image

This allows topic-related builds to be pushed to the registry with a naming scheme based on the project name and topic branch name, allowing for easier testing pathways.

Shell syntax error when containers have errors

docker wait $CONTAINER produces no output when there is no container called $CONTAINER. If this happens (it's happened to me while getting a build working) then there's a shell syntax error at:

https://github.com/anchor/docker-build/blob/master/base#L119

Fix it by wrapping the $RC in quotes.

Add optional docker repo environment variables

We should not be hardcoding afcowie/haskell:latest et al into this project.

Feature: add $DOCKER_REPO variable, and/or $DOCKER_(BUILD/RELEASE)_REPO variables, to allow for custom docker images to be used. Possibly default to the existing ones if not submitted.

This should allow for a build and a release repo, to keep the existing functionality of the system (one image for haskell build widgets, but a pure debian base for the release image).