andreburgaud/crypt2go

Go (golang) ECB mode of encryption and padding.

crypt2go's Issues

Unnecessary padding

I recently import the repo in my work, however, some padding problems occurs:

padLen := p.blockSize - (bufLen % p.blockSize)
this operation set the padding length even if (bufLen % p.blockSize == 0), in which case the buffer is divided exactly
hence no more necessary to pad.
The current codes would catenate an extra and redandunt BLOCKSIZE bytes to the tail of block.

More details refere to NIST Special Publication 800-38A and PULL REQUEST

input not full blocks

Hi, I'm now dealing with aes-128-cbc encoding, but when passing an empty struct to the encode function on README, it gets these error:

crypto/cipher: input not full blocks

I've noticed a quote says padd last block of plaintext if block size less than block cipher size
But no idea what to do
Can you help me with this?
Thanks!

Panic due to slice bounds out of range

There's a potential issue on this line:

crypt2go/padding/padding.go

Line 79 in cc0f5ac

for _, v := range buf[bufLen-padLen : bufLen-1] {

If the input to Unpad is an array in which the last byte is a 0, then this line of code will panic. An error should be returned instead.