andrejtonev/cabpp

C++ header-only library implementing a Cyclic Asynchronous Buffer (CAB)

cabpp's Issues

Copy assignment/constructor will cause a mem-leak when used with pre-allocated memory/objects

When copying a CABpp class, new objects are created by calling "new". This creates a situation where objects are created in heap memory, whose memory is never freed.
This bug is present with both user-allocated memory and user-constructed objects.

The solution would be to disable copy assignment/construction; leaving the move semantics intact. This would lead to a use-case similar to std::unique_ptr.

Add citations

Add citations to the readme file.

Using move semantics with multiple constructors

cabpp/include/cabpp.h

Line 78 in ff01b02

ptrs_.push_back(new T(std::forward<Args>(args)...));

If the T constructor is using move semantics, only the first object will receive the correct arguments.