Giter Site home page Giter Site logo

pysofaconventions's Issues

Possible error in createTestFile.py

In the above mentioned file the variable SourcePositionVar is created by means of sourcePositionVar = rootgrp.createVariable('SourcePosition', 'f8', ('I','C'))
Shouldn't it be sourcePositionVar = rootgrp.createVariable('SourcePosition', 'f8', ('M','C'))? We expect a data that is number of measurements x dimensions (so for example for the MIT KEMAR database with 710 measurements and (azimuth,elevation,distance), we have 710 x 3)

Validity check failing

Using the latest version of your API from PyPI (I assume that is identical to the current version in the repo?). Loading supposedly valid SOFA files like MIT KEMAR (http://sofacoustics.org/data/database/mit/mit_kemar_normal_pinna.sofa) or THK KU100 (http://sofacoustics.org/data/database/thk/HRIR_L2702.sofa).

Checking the validity fails by SOFAWarning: Missing Variable Attribute: ListenerUp.Units and also some other attributes (havn't checked in detail which else yet).

The convention (https://www.sofaconventions.org/mediawiki/index.php/SimpleFreeFieldHRIR) says that these attributes are not mandatory, i.e. optional I suppose. I think we should modify the validity check accordingly?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.