andrewhaine/statamic-accordion-group

Stash groups of fields from long fieldsets away in accordion-style toggle boxes.

statamic-accordion-group's Issues

Conditionals not working within accordion group

Thanks for creating this addon. I have used it in a few projects and it works great to keep the editor clean. However, it seems that using conditionals on fields doesn't work within an accordion group.

For example, I have a simple show of two fields when selecting banner_type for color and image. Both fields end up showing within the accordion group when it should only be showing one field depending upon the selection made to banner_type. The same example works fine when loading it via a partial.

Here the example code:

banner_type:
  options:
    color: Color
    image: Image
  type: select
  default: image
  display: Banner Type
banner_color:
  type: colorpicker
  localizable: true
  width: 33
  display: Background Color
  show_when:
    banner_type: color
banner_image:
  container: main
  folder: /
  restrict: false
  type: assets
  localizable: true
  width: 33
  display: Background Image
  max_files: 1
  mode: grid
  show_when:
    banner_type: image

Screenshot of the accordion group:

A few improvements

Image speaks louder than words.

• Repeated title and instructions
• No padding on the fieldset fields

EDIT:
This works flawlessly when it's not in a replicator.
In the screenshot, the accordion_group is added to a replicator.

Fix for Padding

add this to line 91.

    fieldClasses(field) {
      return [
        "form-group",
        "p-2",
        field.type + "-fieldtype",
        tailwind_width_class(field.width),
        field.classes || ""
      ];
    }

Not sure how we can fix the ReplicatorSet generated headers without changing the name for instruction and title.