andrewimm/wasm-gb

Game Boy emulator in WebAssembly and WebGL 2.0

wasm-gb's Issues

Double free in mir will violate exception safety in this crate.

We detected several double free bugs in your crate via static analysis.
Double free will appear when these function unwind, mainly caused by Box::from_raw & mem::forget.
In Rust Mir, inserting code between Box::from_raw & mem::forget will violate exception safety. Because when these code unwind, the Box generated will drop as well as the entity which ptr pointed to.

wasm-gb/rust/src/lib.rs

Line 115 in b731a89

let mut vm = Box::from_raw(raw);

wasm-gb/rust/src/lib.rs

Line 135 in b731a89

let mut vm = Box::from_raw(raw);

wasm-gb/rust/src/lib.rs

Line 145 in b731a89

let mut vm = Box::from_raw(raw);

wasm-gb/rust/src/lib.rs

Line 155 in b731a89

let mut vm = Box::from_raw(raw);

wasm-gb/rust/src/lib.rs

Line 165 in b731a89

let mut vm = Box::from_raw(raw);

I fixed it by using 'mem::ManuallyDrop' instead of mem::forget, and everything works fine:

Initial Hello / Contributing

Hello! I am also working on a wasm GB emulator over on the wasmBoy repo, and just wanted to say hi! 👋

I've been following your emulator over twitter, and just wanted to chat and offer help! Is there any guide to contributing to the project at all? Though I don't want to steal your personal project from you either haha!

Also, there is a active community of GB Game Devs, and GB Emu Devs from the awesome gb-dev list. There is a discord if you are interested in saying hi! If not no worries, would still love to help out with the project.

Thanks! 😄