andrewmacmurray/elm-concurrent-task

Run a tree of Tasks concurrently, call JS functions as Tasks (Task Ports).

elm-concurrent-task's Issues

Copy API from `Time`

How do you feel about the idea of copying the API from elm/time inside ConcurrentTask.Time?

The idea is that then you can import ConcurrentTask.Time as Time and just use it as if it were the normal Time module.

Multiple pools per ports

Currently it's assumed that you'd use 1 task pool per pair of ports.

However, this is not the case with something like a nested TEA single page app, where it makes sense to have a task pool per page. It's unsafe currently to do this:

• A task is in-flight from one pool (say internally it has an attempt id of 0).
• The user switches pages and immediately starts a task.
• The attempt ids would overlap and there would likely be a weird race condition.

A possible solution would be to add ConcurrentTask.namedPool where you could give a pool a unique name / id - this would prevent race conditions as the runner would know which task pool the responses are associated with.

There may be a way for the pool to initially generate a random id internally before it does any work, but would have to experiment with that and hopefully not break the types

[feature] finallyDo

import ConcurrentTask as CT exposing (ConcurrentTask)

finallyDo : ConcurrentTask e a -> ConcurrentTask e b -> ConcurrentTask e a
finallyDo secondTask firstTask =
    firstTask
        |> CT.onError (\e -> secondTask |> CT.andThenDo (CT.fail e))
        |> CT.andThenDo secondTask

Similar to Javascripts try-catch-finally statement. For example, I'm using finallyDo to make sure unlockResource gets called in both, the success and failure case:

callInsideLock : ConcurrentTask e a -> ConcurrentTask e b
callInsideLock task =
    lockResource
        |> CT.andThenDo task
        |> CT.finallyDo unlockResource

instead of

callInsideLock : ConcurrentTask e a -> ConcurrentTask e b
callInsideLock task =
     lockResource
        |> CT.andThenDo (task |> CT.onError (\e -> CT.andThenDo (CT.fail e) unlockResource))
        |> CT.andThenDo unlockResource

Are you interested in adding this to elm-concurrent-task? I would open a PR if so.

andThenDoOnlyIf

I have two versions of the same function:

import ConcurrentTask as CT exposing (ConcurrentTask)

andThenDoOnlyIf : Bool -> ConcurrentTask Error () -> ConcurrentTask Error () -> ConcurrentTask Error ()
andThenDoOnlyIf shouldProcessTask secondTask firstTask =
    firstTask
        |> CT.andThenDo
            (if shouldProcessTask then
                secondTask

             else
                CT.succeed ()
            )

andThenDoOnlyIf : Bool -> ConcurrentTask Error () -> ConcurrentTask Error () -> ConcurrentTask Error ()
andThenDoOnlyIf shouldProcessTask secondTask firstTask =
    if shouldProcessTask then
        firstTask |> CT.andThenDo secondTask

    else
        CT.succeed ()

The first one does work, the second doesn't execute its second task. Why does the first one work when the if-else is inside the CT.andThenDo function? Any Idea why that is?

implementation question about consuming JSON body

For expect JSON, why does the http body get decoded with .text(). instead of .json()
https://github.com/andrewMacmurray/elm-concurrent-task/blob/1.0.0/runner/http/fetch.ts#L30?

Just something I've noticed looking over the code. Is this intentional?

ConcurrentTask.debug does not work

debug does not print anything to the console. See: https://gist.github.com/ni-ko-o-kin/3c3bd1cccff863c78caa645e24e7970a line 39 and line 41

Steps to reproduce:

npm init --yes
npm install @andrewmacmurray/elm-concurrent-task

cd src
elm install elm/json
elm install andrewMacmurray/elm-concurrent-task

cd ..
elm make src/Main.elm --output elm.js
node main.js

Http Bytes compatibility

It would be nice to make the ConcurrentTask.Http module compatible with elm/bytes.

A popular way seems to be encoding / decoding a Base64 string with a package like this. This however loses most of performance gains of using Bytes.

I'd be curious if anyone has any opinions / alternatives to this.

ConcurrentTask.Time.getZoneName references wrong js function

https://github.com/andrewMacmurray/elm-concurrent-task/blob/1.0.0/src/ConcurrentTask/Time.elm#L86C29-L86C29
uses builtin:timeZoneOffset instead of builtin:timeZoneName.
This seems unintentional?

Just something I've noticed looking through the code, nothing that's bitten me. Much love for making this package 💙