andrewyu0/anticipate

Social posting and voting site for events - anticipate the next exciting thing

anticipate's Issues

Test issue, keep track of features in here

Keep track of features, next items here

Omit 'http://' protocol scheme for links to show

Protocol has to be defined correctly for the links to show. Change this so links without http:// will work

E.g.

As a user I want to be able to post www.espn.com
Currently requires user to input http://www.espn.com

Look into whether resolve objects need to be injected

In angularApp.js, looks like this is working fine:

.state('home', {
    url         : '/home',
    templateUrl : '/home.html',
    controller  : 'MainCtrl',
    resolve     :  ['postsService', function(postsService){
            return postsService.getAll();
        }]
})

vs

.state('home', {
  url: '/home',
  templateUrl: '/home.html',
  controller: 'MainCtrl',
  resolve: {
    postPromise: ['posts', function(posts){
      return posts.getAll();
    }]
  }
})

without having to inject postPromise into the controller. Look into whether or not this is ok

Revisit post route structure, and preload functionality

Revisit the route structure in anticipate/routes/index.js in commit 2b45a51, particularly router.param('post', function(){})

Refactor the way routes with url params are getting called

Look into templating engines that work with ui-router

Implementing views and templates in HTML for now

GET single post: Look into resolve naming, and effect on success() vs then()

This works fine:

state:

.state('posts', {
    ...
    resolve     :  ['$stateParams','postsService', function($stateParams, postsService){
        return postsService.getOne($stateParams.id)
        }] 
});

postsService.getOne:

output.getOne = function(postId){
        return $http.get('/posts/' + postId).success(function(currentPost){
            output.currentPost = currentPost;
        });
    };

in PostsCtrl:
$scope.post = postsService.currentPost;

However, in order to use a named resolve, and inject that resolve in the controller, the state/service needs to be formatted as such:

State:

resolve     : {
    currentPost : ['$stateParams','postsService', function($stateParams, postsService){
        return postsService.getOne($stateParams.id)
    }] 
}

postsService.getOne

output.getOne = function(postId){
    return $http.get('/posts/' + postId).then(function(res){
        return res.data;
    });
};

In order to do the following in the controller:

app.controller('PostsCtrl', [
'$scope',
'currentPost',
function($scope, currentPost){

    $scope.post = currentPost

}]);

Not sure why... I have a feeling it has to do with the res thats coming back from the GET, it's still in the req/res paradigm, which I think I had to use then() vs success(). Check out a resource like this: To then() or to success() in AngularJS

Action item : Create new branch and experiment