andreystepanov/hashids.sql

PL/pgSQL implementation of hashids library

hashids.sql's Issues

Incorrect encoding for 0 value.

The implementation of the hashids.to_alphabet function leads to different encodings for the value 0 compared to implementations in other languages. Specifically, if current_number begins as 0 the function is essentially skipped.

hashids.sql/hashids.sql

Line 13 in 3464d83

while current_number > 0 loop

Python:
https://github.com/davidaurelio/hashids-python/blob/09f879a1967836f1e399c12b745c24291e3e73ad/hashids.py#L43

Ruby:
https://github.com/peterhellberg/hashids.rb/blob/b729fe514e492e18d9f69473b53eb59a3b5aee4b/lib/hashids.rb#L163

Custom alphabet produces different results than other libraries

Thank you for getting this off the ground! In doing some playing around I noticed that I got different results when I used a custom alphabet using your library than through the Javascript or Ruby versions.

I used this codepen from Ivan Akimov to test the JS version:
https://codepen.io/ivanakimov/pen/bNmExm

ID: 1 / salt: 'salt' / no custom alphabet - OK
Javascript: XG
Ruby: XG
PL/SQL: XG

ID: 1 / min_length: 6 / salt: 'salt' / no custom alphabet - OK
Javascript: xkXG8Z
Ruby: xkXG8Z
PL/SQL: xkXG8Z

ID: 1 / min_length: 6 / salt: 'salt' / alphabet: 'ABCDEFGHIJKLMNOPQRSTUVWXYZ' - ERROR
Javascript: MEPWMP
Ruby: MEPWMP
PL/SQL: JPRAPM

I wish I could offer more assistance.