ans-hub/wumpus_game

MVC based game "Hunt the wumpus"

wumpus_game's Issues

The function `void Observable<T...>::UnregisterObserver` in observable.h has error

template<class...T>
void Observable<T...>::UnregisterObserver(Observer<T...>& o)
{
  observers_.erase (
    std::remove(o->begin(), o->end(), o), o->end() 
  );
}

First, Is o->begin() and o->end() should be observers_.begin(), observers_.end()?
Second, std::remove() compiler error has type of observers_.begin().

I'm newer for C++, so I fix the bug is rookie:

  for (size_t idx = 0; idx < observers_.size(); ++idx) {
    auto& it = observers_.at(idx).get();
    if (&it == &o) {
      observers_.erase(observers_.begin() + idx);
    }
  }

Is there a better way? Please you help me, thanks!