Allow CSS Variables theme

[PuruVJ]

Allow CSS Variables theme

[antfu]

I personally would feel using a CSS-variables theme would lose the point of using Shiki in the first place, as it produced much less accurate results (in that case, it would be closer to Prism or another syntax highlighter). Plus that I think that previous theme design is kinda under the assumption of Web-related languages, while some token types might not even make sense in other languages.

The CSS variable theme is removed on purpose because of the drawback and the requirements of special handling. Which I am still not very convinced to have it.

Can you elaborate more on why this makes it hard to migrate? Is you want to keep exactly the same styling as the current theme strictly?

[antfu]

Tried a more agnositc approach #68, happy to hear what you think :)

[PuruVJ]

Wow that's a real quick PR! 👑

Can you elaborate more on why this makes it hard to migrate? Is you want to keep exactly the same styling as the current theme strictly?

It would require hard-coding the colors into shiki theme as well, both light and dark. Those colors would have to coexist with the CSS variables, leading to duplication.

Tried a more agnositc approach #68, happy to hear what you think :)

This one is nice!! I noticed you mentioned reinstating the CSS Variables approach. That would be ideal, but if it's too much tech debt, I'd still be happy using colorReplacements approach. An example of doing that in the docs would be appreciated!

Again, thanks for such a quick response!

[antfu]

https://shikiji.netlify.app/guide/theme-colors#css-variables-theme

Let me know if this unblocks your usage