Additional types for ThemeRegistrationResolved

[antfu]

Additional types for ThemeRegistrationResolved

[antfu]

Would you elaborate more on why they are needed?

[gdomingu]

These two types are included for high contrast themes from VS code. https://github.com/microsoft/vscode/blob/0a08e6fdcd514741ceb679fb38c746550b5aabf3/src/vs/platform/theme/common/theme.ts#L12-L13

[antfu]

I knew. But it doesn't explain why you need it. High-contrast or not, it might make sense to VS Code as an editor. But we are only focusing on syntax highlighting, where the type is used to infer the default background color. Contrasty is presented in the colors themselves.

[gdomingu]

I think it is needed for compatibility with VS code themes. If someone exports a high contract theme from VS code and tries to pass it into shikiji they will get a type error. One of the main selling points of this library is the compatibility with VS code themes.

[antfu]

Can you give a bit more concrete example of what your usage is? Which theme do you want to pass in?

[gdomingu]

These themes
https://github.com/microsoft/vscode/blob/main/extensions/theme-defaults/themes/hc_light.json
https://github.com/microsoft/vscode/blob/main/extensions/theme-defaults/themes/hc_black.json

But I notice that type doesn't seem to be present on those JSON files. But shows up when you export the theme in VS code.

[antfu]

#73 (comment)