antonok-edm/ampli-fe

Fully cross-platform VST2 plugin with a custom editor UI, written in Rust.

ampli-fe's Issues

Plugin crashes when used in reaper

I tried to load the plugin with reaper 6.34, the program crashes (using Ubuntu 20.04):

$ ./reaper jack: created client jack: setting TIME_CRITICAL = 4 jack: activated client MESA-INTEL: warning: Ivy Bridge Vulkan support is incomplete thread '<unnamed>' panicked at 'calledOption::unwrap()on aNonevalue', src/editor/interface/graphics.rs:111:18 note: run withRUST_BACKTRACE=1environment variable to display a backtrace fatal runtime error: failed to initiate panic, error 5 Aborted (core dumped)

I guess there is a problem with my gpu. It is an integrated GPU. sudo lshw -C display gives
*-display description: VGA compatible controller product: 3rd Gen Core processor Graphics Controller vendor: Intel Corporation physical id: 2 bus info: pci@0000:00:02.0 version: 09 width: 64 bits clock: 33MHz capabilities: msi pm vga_controller bus_master cap_list rom configuration: driver=i915 latency=0 resources: irq:36 memory:62000000-623fffff memory:70000000-7fffffff ioport:3000(size=64) memory:c0000-dffff

Loading the plugin with ardour seems to work as expected.

(A minor issue might be that when the plugin is compiled in debug I get an overflow when loading the plugin:
MESA-INTEL: warning: Ivy Bridge Vulkan support is incomplete thread '<unnamed>' panicked at 'attempt to subtract with overflow', src/editor/interface/state.rs:77:20 note: run with RUST_BACKTRACE=1environment variable to display a backtrace fatal runtime error: failed to initiate panic, error 5 Aborted (core dumped)) (fixed in #3)

Verifying Auto-Vectorization for SIMD

ampli-Fe/src/dsp/mod.rs

Line 45 in a4af5ad

// To take advantage of SIMD auto-vectorization, and for consistent parameter smoothing,

While reading though the dsp code, I was wondering if the chunking for auto-vectorization is necessary. While reading this blog post, I was wondering if the chunking might even prevent AVX SIMD optimization, compared to iterator-based loops.

I played around a bit: https://godbolt.org/z/YaYoW71jT
Add -C target-feature=+avx2 to enable AVX.

DAW specific VST3

I intend to do a plugin dedicated for Reaper in Rust.
When researching I found ampli-Fe which seems promising as a starting point.
What I seem to need is

• VST3
• "DAW specific extension" to VST3. This obviously is not something ampli-Fe can help, but it's a VST (2+3=) thingy. Obviously I only can do research on that when I know I can use VST3.
  Regarding ampli-Fe based user interface: I need top do something like a left/right and up/down pannable spreadsheet that should live in a Window providing multiple tabs for showing certain aspects of the application. Is something like that sensible with WGPU or should I search for some other GUI crate ?

Thanks for any pointers,
-Michael

[Feature request] StudioRack integration

It's an open-source plugin manager called StudioRack:
https://github.com/studiorack

The aim of the project is to provide a free open-source way to manage plugin dependencies and their versions. It would involve the following steps:

Publish a Github release containing the plugin source along with metadata plugins.json
Tag your Github repository with studiorack-plugin so it can be discovered
Wait for the studiorack-registry to index your plugin (every 24 hours)
Check the registry feed for your plugin to appear

What is VST2?

Could you please include a link to a meaningful VST2 page, the first time the string appears in the README?
Plus maybe also a tiny, short description of what it is, in-line, like: "... VST2 plugin (a virtual music studio) ...".

Like me, many people will come to this project because they saw it as an example on the wgpu website,
so the chance that they know what VST2 is is relatively low.

VST3

HI ampli-Fe Community !
Many thanks for providing this code !

I intend to do a plugin dedicated for Reaper in Rust.
When researching I found ampli-Fe which seems promising as a starting point.
So I did compile and test ampli-Fe in Reaper and it works perfectly as expected.

I am concerned about it being done using VST2 because of two reasons:

• VST2 is depreciated by Steinberg, and you are not allowed to distribute your work (eithetr5 as open source nor closed) which is based on VST2 unless you already own a (at that time free) VST2 SDK license. But since quite some time, VST2 SDK licenses are not provided by Steinberg any more. That is why any new VST work needs to use the VST3 API.
• VST3 provides obvious advantages. Regarding the GUI (seems like the main purpose of ampli-Fe) this is scalability. With VST3 the Window size of the plugin can adapt to the window size the user manages by managing the Window the DAW provides for the plugin.

Any chance for using VST3 for ampli-Fe ?
Thanks a lot,
-Michael

CLAP example

It'd be nice to create a CLAP version of ampli-Fe. The UI code can likely be shared.

Why CLAP?

• the VST2 plugin standard is deprecated
• the VST3 plugin standard has some threading constraints that are hard to reconcile in Rust
  • technically, VST2 has those too, but I ignored them here 😅
• CLAP has a more modern design
• CLAP has a royalty-free license (MIT)

UI doesn't work correctly in Bitwig under MacOS

UI looks like this and the knob doesn't turn on MacOS 11.6 on Bitwig 4.1.6

UI doesn't render in Ableton Live 10 on Windows

Steps for repro:

• Built using cargo build --release
• copied .dll file to main folder for Ableton plugins
• Open plugin as normal, but the screen is blank (white canvas).

*Note: I'm a complete novice for vst dev, and just wanted to explore where to start: i.e. In no rush, but wanted to see if I could compile something from scratch.

Release binaries

Hi there, thanks for open-sourcing your code and releasing your plugin.

Would you be able to publish binaries for linux, mac and windows? So that every persons doesn't need to build it themselves? You can upload them as a GitHub release.

It's also possible to add a Github workflow which will build you plugin automatically for each platform in a pipeline. I don't have an example for Rust, but for VST3 plugins:
https://github.com/studiorack/studiorack-plugin-steinberg/blob/main/.github/workflows/release.yml#L28

Thanks!