Proposal: [ANDROID] move inAppBrowser intents from onPageStarted to shouldOverrideUrlLoading

[apache]

Proposal: [ANDROID] move inAppBrowser intents from onPageStarted to shouldOverrideUrlLoading

[jcesarmobile]

Original message:

I've been looking into issues and I have seen this one:
https://issues.apache.org/jira/browse/CB-8180

Right now the code to handle the tel links is inside the onPageStarted

if (url.startsWith(WebView.SCHEME_TEL)) {
try {
Intent intent = new Intent(Intent.ACTION_DIAL);
intent.setData(Uri.parse(url));
cordova.getActivity().startActivity(intent);
} catch (android.content.ActivityNotFoundException e) {
LOG.e(LOG_TAG, "Error dialing " + url + ": " + e.toString());
}
}

But the problem is, it launchs the intent and try to open the web page, so when you come back from the intent you see a "couldn't load the url" page on the app.

I've tried to use the view.stopLoading() but it doesn't seem to stop it.
The issue only talks about the tel links, but I suppose that will happen with sms, mailto and some other links.

So, I think a solution might be to move that code to shouldOverrideUrlLoading function.

Is there any reason of doing this on the onPageStarted instead of using the shouldOverrideUrlLoading?

[jcesarmobile]

@agrieve answer:
shouldOverrideUrlLoading is what the main cordova webview uses, so that's
certainly the right approach. I believe it should also add
CATEGORY_BROWSABLE to the intent to ensure that the user is prompted to
confirm whether they actually want to make the call.

[jcesarmobile]

The issue has been now assigned to @infil00p and on his comment on the issue he said:
This will probably be discussed on the list.

But I don't remember seeing this discussed on the mail list appart from my mail.

[infil00p]

I asked what this should do in the ideal case. It should be in
InAppBrowser's shouldOverrideUrlLoading. Like most of our plugins, I kinda
want to re-write it all, but doing that just shows that I don't know what's
going on with this plugin. I think there's two issues that are directly
related to what you just talked about on this.

On Mon, Jun 22, 2015 at 1:44 PM Julio César [email protected]
wrote:

The issue has been now assigned to @infil00p https://github.com/infil00p
and on his comment on the issue he said:
This will probably be discussed on the list.

But I don't remember seeing this discussed on the mail list appart from my
mail.

—
Reply to this email directly or view it on GitHub
#10 (comment)
.

[jcesarmobile]

The issue was resolved long time ago, closing...