Remove usage of cordova-common/superspawn

[janpio]

Remove usage of cordova-common/superspawn

[raphinesse]

To provide more context: cross-spawn only improves cross-platform compatibility of child_process.spawn while replicating it's interface. execa builds on top of that and adds various other features, like a nicer Promise-based interface (similar to superspawn) cross-platform shebang support (would be useful for HooksRunner) and a lot more. And lastly we do not have to maintain execa. That's a big plus.

So yes, we want something a bit more high-level than cross-spawn, but I'd prefer execa over superspawn.

[raphinesse]

I'd like to finally resolve this issue and #7, so I'm going to try and finish the transformation we started here.

[raphinesse]

I think we want to replace superspawn invocations with execa invocations, not cross-spawn.

[janpio]

This goal of this issue is to "Remove usage of cordova-common/superspawn". execa is an implementation detail. When someone gets around to implement this, it might very well be that it makes sense to use something else or newer.

[janpio]

Whatever works, I was getting this from apache/cordova-common#50 but exaca looks great as well. On the other hand, that might show that we may not want to get rid of the wrapper after all - preferences seems to change here.

[brodybits]

I think we want to replace superspawn invocations with execa invocations, not cross-spawn.

Why not use execa and skip cross-spawn?

[raphinesse]

@brodybits That is what I'm suggesting. Or I don't understand the question.

[brodybits]

I am getting a bit confused here.

#16 (comment) and #16 (comment) indicate to me that we should skip cross-spawn and use execa right away, while apache/cordova-common#50 (comment) and apache/cordova-common#50 (comment) indicate to me that we take a two-step process (use cross-spawn first then use execa).

I would personally favor the two-step process:

• first use cross-spawn as proposed in apache/cordova-common#50 to solve the problem
• then we migrate to execa and get rid of our cordova-common/superspawn as discussed here

@raphinesse can you please straighten me out here?

I would also like to motion that we hide or remove the following comments as "off-topic":

• apache/cordova-common#50 (comment)
• apache/cordova-common#50 (comment)
• apache/cordova-common#50 (comment)

[raphinesse]

@brodybits Now I understand. Yes, I would favor a two step process too since migration to execa could take quite some time.

I hid the comments you referred to as "resolved"

[janpio]

apache/cordova-common#50 is one PR, doing one thing.
This, #16, is another issue, suggesting the doing of another thing. (At first it was "replace superspawn with cross-spawn", after comments from @raphinesse it is "replace superspawn with execa").

These are not related only in that this issue only makes sense after apache/cordova-common#50 has been merged to remove the Windows specific handling.

[brodybits]

Thanks Raphael for the perfect disposition. Thanks Janpio for the clarification. I would like to make another motion to put execa into the title and description of either this issue or a new issue.

[brodybits]

Another rationale I gave in #7 (comment) is that superspawn seems to return a non-standard Promise-like object that can also notify the listener of stdout and stderr data. I think getting rid of superspawn would really help finish getting rid of q (#7).