Giter Site home page Giter Site logo

Comments (9)

IronCore864 avatar IronCore864 commented on June 20, 2024 2

I did some research, and I want to support this proposal.

Draft PR: #140

Below are my detailed proposal; requesting for comments:


1 Background

The current situation:

  • DevLake supports both Docker compose, and Helm install
  • self-created Grafana Docker image with customized dashboard/datasource definition
  • Grafana Docker image releases together with DevLake, the Grafana version isn't the latest and can't be specified
  • DevLake Helm chart defines a customized Grafana Deployment/Service/Ingress/ConfigMap

2 Proposal

Disconnect DevLake with Grafana. By "disconnect", I mean:

  • remove the grafana folder from apache/incubator-devlake helm chart
  • move the customized dashboard/datasource definition to the apache/incubator-devlake-helm-chart repo
  • remove Grafana related K8s manifests from apache/incubator-devlake-helm-chart
  • use the official Grafana helm chart as a dependency for the DevLake helm chart

3 Pros and Cons

  • reduce DevLake Helm chart complexity
  • no reinventing wheels
  • customize Grafana version

from incubator-devlake-helm-chart.

IronCore864 avatar IronCore864 commented on June 20, 2024 1

I will do some investigation on this one. Please assign this issue to me. @klesh

from incubator-devlake-helm-chart.

klesh avatar klesh commented on June 20, 2024 1

Sounds good to me overall.
However, we should also address the following problems:

  1. The dashboards are highly dependent on the Domain Layer definition from the devlake repo, How do we keep track of them? e.g. dashboards developed for v0.18 might not work on v0.17. Keep in mind we have to make old dashboards should be upgraded or downgraded automatically while users upgrade/downgrad the helm chart. @IronCore864
  2. Currently, we have some dashboards specifically designed for data verification (for both Testing and Debugging), should we deploy the helm in order to do so? if so, we should set up an automated CD system for testing. @IronCore864 @abeizn
  3. How do we and users develop new dashboards or upgrade existing ones, we need documents to guide users on how to do so and submit their contribution. @IronCore864 @Startrekzky

from incubator-devlake-helm-chart.

klesh avatar klesh commented on June 20, 2024

Look good to me, @matrixji @IronCore864 what do you think?

from incubator-devlake-helm-chart.

JorgeGar avatar JorgeGar commented on June 20, 2024

I guess the same could also be done for MySQL too.

from incubator-devlake-helm-chart.

IronCore864 avatar IronCore864 commented on June 20, 2024

Yes, I agree that maybe we can use the official chart for mysql/grafana as dependencies.

from incubator-devlake-helm-chart.

hezyin avatar hezyin commented on June 20, 2024

Good idea. Does Grafana's official chart support provisioning dashboards?

from incubator-devlake-helm-chart.

JorgeGar avatar JorgeGar commented on June 20, 2024

Good idea. Does Grafana's official chart support provisioning dashboards?

Yes it does. On that sense it could be also interesting to see if it is possible to offer the dashboards to the user’s already existing Grafana.

from incubator-devlake-helm-chart.

klesh avatar klesh commented on June 20, 2024

How do we release, sop doc update

from incubator-devlake-helm-chart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.