apivideo/api.video-api-client-generator

Tool used to generate api.video's API clients, based on OpenAPI codegen

api.video-api-client-generator's Issues

[nodejs] RawStatisticsApi.listVideoSessions() metadata parameters issue

@dougsillars found an issue on the nodejs client. This issue probably affects other clients also.

The metadata param on the RawStatisticsApi.listVideoSessions() endpoint should be an object that is serialized as follow in the request query:

• metadata: {'key1': 'value1', 'key2': 'value2'}
• request url: blabla?metadata[key1]=value1&metadata[key2]=value2

I think the schema isn't properly defined in the API description (maybe we should deal with the "style" attribute of the param in the description). I also think it will need a change in the nodejs generator.

@lutangar let's talk about that next week when you're avaliable.

test

this is a test

[Feat]: Video Screenshot API

Version

Environment that reproduces the issue

Use case description

Hey guys,
would be great if there would be an API to request a screenshot from a video for a specific timestamp.
Thanks for your great work and considering!

Proposed solution

No response

Alternative solutions

No response

Analytics API namespace

While working on the migration guide I notice the following difference:

Get video analytics sessions for the current year

Before: (nodejs-sdk)

await client.analyticsVideo.get(videoId, new Date().getFullYear());

After: (typescript-client)

await client.rawStatistics.listVideoSessions({ videoId, period: new Date().getFullYear().toString() });

Nothing wrong here, except the statistics wording feels wrong.

If we look at the analytics docs:
https://docs.api.video/reference#analytics

We usually reference it as analytics.
About the raw part, I remember it was a thing before but not sure it matters now.

We might as well call it analytics :

await client.analytics.listVideoSessions({ videoId, period: new Date().getFullYear().toString() });