Comments (18)
Hey @keith,
We are planning on releasing a beta version SDK to support SDWebImage 4.0 around the end of this week or early next week. Is the timeline good for you?
Thanks,
Wenzhi
from appboy-ios-sdk.
Is the SDWebImage GIF subspec required for the UI portion of Appboy? This adds another library to our project 😞
from appboy-ios-sdk.
Hey @mlloyd,
Thanks for reporting the issue! However, your issue doesn't relate to the original issue here. Could you create a separate issue following our issue template? It will help collecting more necessary information and stop notifying other people in this thread with an unrelated issue.
Let's move the discussion to your issue thread! We will try to solve as fast as we can.
Thanks,
Wenzhi
from appboy-ios-sdk.
Hi Keith,
It makes total sense not to include SDWebImage if you don't use or plan on using Appboy's UI features. The reason we force it as a dependency is because the current SDK's built-in in-app message feature will crash on display without SDWebImage present. Forcing everyone to include SDWebImage allows clients who don't currently use in-app messages to try them out later without worrying about crashes on older apps.
It's on our roadmap to separate the SDK into two parts: base and UI and we are working on it as we speak. When finished, we will change the podspec to different subspecs. It will not be finished in the near future, but we will let you know right away when it's done.
If you have any suggestions about how we can make things easier for you, or any other questions, please let us know.
Thanks,
Wenzhi
from appboy-ios-sdk.
Thanks! We'll keep an eye out for the split update!
from appboy-ios-sdk.
👍
from appboy-ios-sdk.
👍
from appboy-ios-sdk.
👍
from appboy-ios-sdk.
Any update on the split here? Otherwise do you have any plans to upgrade SDWebImage to the newest major release?
from appboy-ios-sdk.
Sounds good, thanks!
from appboy-ios-sdk.
Hey @keith,
We released the 2.26.0-beta version with SDWebImage 4.0 support over the weekend. It would be great if you can try it out and let us know any issue or problem you see.
Thanks,
Wenzhi
from appboy-ios-sdk.
Hey @Wenzhi
I have tried the Carthage 2.26.0-beta but the SDWebImage framework isn't working. Comparably with the version built direct from SDWebImage using Carthage.
I believe the issue is due to your zip including, the SDWebImage framework. Which is not the correct module header. It's incorrectly labelled, SDWebImage_umbrella.h Normally the include would be, #import <SDWebImage/SDWebImage.h>
For reference;
https://github.com/rs/SDWebImage/blob/4.0.0/WebImage/SDWebImage.h
Thanks, Martin
from appboy-ios-sdk.
Hey @keith,
We are currently working on creating a core suspec with no dependency to solve this specific issue. There is no timeline for the release yet but it should be in the near future. I'll inform you in this issue thread as soon as it comes out. Please stay tune :)
Thanks,
Wenzhi
from appboy-ios-sdk.
We are not using any of the ui components. Having model and UI in the separate repos would be the best option for us.
from appboy-ios-sdk.
@keith/all,
We just released version 2.26.0 with two subspecs: Core
and UI
. The Core
subspec has no dependencies. If you don't use Appboy UI components and want to include our library without dependencies, please change your Podfile to use Appboy-iOS-SDK/Core
.
If you use the Core
subspec - in the future you may want to message users using Appboy's UI, and shipping a version without our full library can introduce friction. For example, you may have to version-filter delivery of in-app messages and News Feed items.
Note: there are still resource files in the Core subspec. Eventually all UI items will be moved to the UI
subspec.
For more information, please see (CHANGELOG.md)[https://github.com/Appboy/appboy-ios-sdk/blob/master/CHANGELOG.md]. Please let us know if you see any issue or have any questions.
Thanks,
Wenzhi
from appboy-ios-sdk.
@Wenzhi
Is it possible to use the core version with Carthage?
from appboy-ios-sdk.
Hey @mlloyd,
Currently, our Core subspec does not have Carthage support because we support through a pre-built framework of our entire library. We are actively considering strategies for more robust Carthage support but don't have any plans for an immediate change here. We will keep you posted when we have more information.
I created a separate issue here to keep track of this Carthage support.
Thanks,
Wenzhi
from appboy-ios-sdk.
Hey All,
I'm going to close this issue as we now provide Core SDK without dependency on Cocoapods. If you see any issues or have any questions, please create an issue and let us know. :)
Thanks,
Wenzhi
from appboy-ios-sdk.
Related Issues (20)
- [Feature]: Modal In-app message could be dismissed also by tapping on blurred background HOT 2
- Test Issue
- [Bug]: Appboy-iOS-SDK 4.4.3 + not Archiving with Bitrise HOT 3
- [Bug]: Appboy ios SDK 4.4.4 archive failed HOT 4
- [Bug]: Blank UIWindow when IAM received HOT 2
- [Feature]: Need Asynchronous callback when dispatch to server is completed HOT 6
- [Bug]: Geofence not working at all HOT 2
- [Bug]: Previews not working on Xcode 14.X HOT 6
- [Bug]: ABKUIUtils.activeWindowScene sometimes is wrong HOT 3
- [Bug]: Background Task will cause a risk of termination from [ABKService processRequest:] HOT 4
- [Bug]: Appboy 4.5.2 has been crashed when try to use method "logPurchse:" HOT 8
- [Bug]: UI unresponsiveness if invoked on the main thread HOT 3
- [Feature]: methods for handling `brazeAction` uri's HOT 1
- [Bug]: Push notification received after `Appboy.disableSDK` HOT 4
- [Feature]: HOT 2
- [Bug]: SDWebImage dependency. HOT 1
- [Bug]: ABKCustomPropertyUtils validateArray HOT 6
- [Bug]: From 4.2.0 to 4.5.4, deviceToken registration fails. No push dialog box is displayed HOT 9
- [Feature]: Upgrade SDWebImage to latest HOT 6
- [Bug]: 0x1b4ea62b8 __CFBinaryPlistWriteOrPresize + 556 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appboy-ios-sdk.