Carthage integration

[appboy]

Carthage integration

[billmag]

@rskuja -- apologies for the delays on our side, but thank you for doing this! We'll aim to fold this into official support for the next point release we do.

[rskuja]

I was also in need for Carthage support so i made a fork and published release with Carthage support.
Available here: https://github.com/fullcontact/appboy-ios-sdk
To install add this to Cartfile:
github "fullcontact/appboy-ios-sdk" "2.19.1"

This is only temporary until AppBoy team will add official support.

Only thing required to add basic Carthage support is publish release along with zipped framework so Carthage can download it. Example here: https://github.com/fullcontact/appboy-ios-sdk/releases/tag/2.19.1

[briancaw]

Hi @hovox,

Thanks for giving us this signal - we'll strategize around Carthage support and update with a timeline ASAP.

Brian

[justin]

I would like this too. We asked for it when we were on boarding, but never really got a timeline.

[davidblaesing]

@billmag When are you planning to make a new release including shared carthage scheme?

[briancaw]

Hey All,

We are planning on releasing Carthage support in our next release, which will come out this week. We had intended to put this in 2.19.3 but the release timeline for 2.19.3 was moved forward and this had to be pushed out a release - apologies again for the delay.

Support will be in the form of a zipped framework attached to the release. Please let us know if there are any further comments/questions.

Thanks,
Brian

[Wenzhi]

Hey @hovox, @justin and @davidblaesing,

Appboy SDK version 2.20.0 has been released with Carthage support. Please let us know if you have any further comments, questions or suggestions. Thank you very much for helping improve Appboy's SDK!

Also, special thanks to @rskuja for the help here!

Thanks,
Wenzhi

[shanev]

@Wenzhi I'm getting the following error after switching to Carthage:

dyld: Library not loaded: @rpath/SDWebImage.framework/SDWebImage
  Referenced from: ../Frameworks/Appboy_iOS_SDK.framework/Appboy_iOS_SDK
  Reason: image not found

SDWebImage is also installed via Carthage, but the framework name is WebImage.framework, not SDWebImage.

[Wenzhi]

Hi @shanev,

Your issue looks similar to this issue:Carthage/Carthage#616. Could you confirm that:

• In your Build Settings, the "Framework Search Paths" includes: $(PROJECT_DIR)/Carthage/Build/iOS (and the directory is the correct one)
• Also in your Build Settings, the "Runpath Search Paths" includes: $(inherited) and @executable_path/Frameworks
• In your Build Phases, there is "Embedded Framework". If not, you can follow @ikesyo's comments in Carthage/Carthage#615 (comment):

you should add a new "Copy Files Phase," then select "Frameworks" for Destination, add frameworks to the list, and check "Code Sign On Copy" checkboxes.

I see you also mentioned you installed the SDWebImage via Carthage. Could you send us your Cartfile so we can try to repo the issue?

Thanks,
Wenzhi

[davidblaesing]

@shanev We have one problem with "SDWebImage.framework".
Are you using https://github.com/rs/SDWebImage as dependency? Because we are getting a "WebImage.framework" from https://github.com/rs/SDWebImage on v3.7.6
This causes that we have duplicated functions in frameworks. Can you please update that dependency?

best,
David

[briancaw]

Hey all,

It's not entirely clear why SDWebImage modified their name for their Framework build - some other folks have called this out as an issue; see SDWebImage/SDWebImage#1467. As for our Carthage support, we bundle SDWebImage in the release zip with the proper name, i.e. SDWebImage.framework which works with the Framework we release. @davidblaesing @shanev Are you able to use the SDWebImage Framework that we bundle into our release?

Please let us know any further questions/comments.

Thanks,
Brian

[justin]

Speaking for @shanev, we were able to switch to the bundled SDWebImage. Still hoping for #46 to land so we can remove our dependency on SDWebImage entirely.

[Wenzhi]

Hey All,

We released Carthage support this past May in version 2.20.0. I'm going to close this issue. Please let us know if you have more questions or issues regarding Carthage integration.

Thanks,
Wenzhi